| Summary: | ASTERISK-03829: [patch] pbx_spool | ||
| Reporter: | Matthew Nicholson (mnicholson) | Labels: | |
| Date Opened: | 2005-03-31 18:37:34.000-0600 | Date Closed: | 2008-01-15 15:29:44.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) pbx_spool.diff.txt ( 1) pbx_spool2.diff.txt | |
| Description: | PBX spool ignores the last line in a spool file. The spool reads a line and if it is at the end of the file it quits reading without processing the current line. This patch makes it process that last line. ****** ADDITIONAL INFORMATION ****** Disclaimer on file, patch attached. | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-03-31 21:57:24.000-0600 Committed a slightly different fix to CVS, thanks! By: Russell Bryant (russell) 2005-03-31 22:24:46.000-0600 fixed in 1.0 By: Matthew Nicholson (mnicholson) 2005-04-01 09:29:13.000-0600 New patch attached. Slightly different. Uses fgets to determine when to stop reading. The rest of the patch is indentation changes. By: Kevin P. Fleming (kpfleming) 2005-04-01 09:51:20.000-0600 Please don't re-open a bug when the solution has already been committed. In this case, your alternative solution may or may not be better, but it should eb discussed in a separate bug. Also, the coding guidelines strongly recommend not combining whitespace/formatting fixes with code changes when possible, because that way the CVS commits will be kept separate and it's easier to find problems caused by code changes. By: Digium Subversion (svnbot) 2008-01-15 15:29:44.000-0600 Repository: asterisk Revision: 5334 U branches/v1-0/CHANGES U branches/v1-0/pbx/pbx_spool.c ------------------------------------------------------------------------ r5334 | russell | 2008-01-15 15:29:44 -0600 (Tue, 15 Jan 2008) | 2 lines process the last line, even if it doesn't have a newline char (bug ASTERISK-3829) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5334 | ||