| Summary: | ASTERISK-03827: [patch] Add category to events | ||
| Reporter: | Olle Johansson (oej) | Labels: | |
| Date Opened: | 2005-03-31 14:33:58.000-0600 | Date Closed: | 2008-01-15 15:30:28.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) eventcategory.txt ( 1) eventcategory.txt ( 2) eventcategory.txt ( 3) eventcategory.txt | |
| Description: | This patch adds category to events. This is to assist the manager proxy to sort out security filters in the proxy itself, so we can have one login from the proxy with full access. Disclaimer on file. ****** ADDITIONAL INFORMATION ****** We might need to go through and revise the categories as well, it doesn't seem to be fully implemented in all manager commands... | ||
| Comments: | By: Olle Johansson (oej) 2005-03-31 14:41:32.000-0600 Added updated patch that includes categories in the "listcommands" AMI command. By: Olle Johansson (oej) 2005-03-31 14:57:29.000-0600 Third version with cosmetic changes, typo fixes and new improved synopsis help texts for "show manager commands"... By: Kevin P. Fleming (kpfleming) 2005-04-01 10:53:11.000-0600 This hunk: @@ -506,7 +509,7 @@ ast_mutex_lock(&actionlock); while (cur) { /* Walk the list of actions */ if ((s->writeperm & cur->authority) == cur->authority) - ast_cli(s->fd, "%s: %s\r\n", cur->action, cur->synopsis); + ast_cli(s->fd, "%s|%s|%s\r\n", cur->action, authority_to_str(cur->authority, temp, sizeof(temp)), cur->synopsis); cur = cur->next; } ast_mutex_unlock(&actionlock); appears to break backwards compatibility by changing the format of the command's output. Any existing manager API using this command will no longer be able to parse the output... do we need to be concerned about that? By: Olle Johansson (oej) 2005-04-01 10:54:41.000-0600 Right, I'll mail the list. By: Olle Johansson (oej) 2005-04-03 15:19:19 * Changed the header to "Privilege" to be backwards compatible * Changed the output Kevin mentioned back, just added a (Priv: %s) on each line. That should not hurt parsing, since the comment is never parsed anyway. By: Kevin P. Fleming (kpfleming) 2005-04-03 15:29:43 OK, that looks good, with only one possible change: 'Privilege' should be 'Privileges'. Thoughts? By: Mark Spencer (markster) 2005-04-03 18:36:21 Looks good to me too. By: Olle Johansson (oej) 2005-04-04 01:27:23 It's "Privilege:" in other parts of manager and I don't want to break that or invent new things if not needed... By: Kevin P. Fleming (kpfleming) 2005-04-04 11:25:32 Committed to CVS, thanks! By: Russell Bryant (russell) 2005-04-05 01:37:04 not included in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:30:28.000-0600 Repository: asterisk Revision: 5385 U trunk/manager.c ------------------------------------------------------------------------ r5385 | kpfleming | 2008-01-15 15:30:27 -0600 (Tue, 15 Jan 2008) | 2 lines make the manager interface list the privileges required for each command (bug ASTERISK-3827) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5385 | ||