[Home]

Summary:ASTERISK-03818: [patch] wrong usage of rtpchecksums
Reporter:cherso (cherso)Labels:
Date Opened:2005-03-31 07:27:41.000-0600Date Closed:2008-01-15 15:30:39.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) rtpchecksums.diff
Description:when rtpchecksums=yes
wrong use of the function ast_true

if ((s = ast_variable_retrieve(cfg, "general", "rtpchecksums"))) {
#ifdef SO_NO_CHECK
                       if (ast_true(s))
                               checksums = 1;
                       else
                               checksums = 0;

and then when checksums=1 sesockopt set the NO_CHECK

#ifdef SO_NO_CHECK
               if (checksums) {
                       setsockopt(s, SOL_SOCKET, SO_NO_CHECK, &checksums, sizeof(checksums));
               }
#endif
Comments:By: Olle Johansson (oej) 2005-03-31 08:05:04.000-0600

Is this patch disclaimed?
By: cherso (cherso) 2005-03-31 08:15:06.000-0600

I can't send the disclaimer right now, it's just a quick fix so please add it
By: Kevin P. Fleming (kpfleming) 2005-03-31 12:49:40.000-0600

I think it's safe enough to accept this without a disclaimer, since it's trivial (just swapping two numbers).
By: Kevin P. Fleming (kpfleming) 2005-03-31 12:52:01.000-0600

Actually, the patch is not quite right, since it doesn't change the warning message generated when SO_NO_CHECK is not supported. I'll get something ready to be committed :-)
By: Kevin P. Fleming (kpfleming) 2005-03-31 13:20:20.000-0600

Committed to CVS with minor modifications, thanks!
By: Olle Johansson (oej) 2005-04-01 06:30:59.000-0600

On request.
By: staffanu (staffanu) 2005-04-01 06:41:04.000-0600

CVS HEAD does not compile on machines that do not have SO_NO_CHECK defined: Line 8254 och chan_iax2.c sets nochecksum to zero with no surrounding #ifdefs.

edited on: 04-01-05 06:41
By: Kevin P. Fleming (kpfleming) 2005-04-01 09:59:39.000-0600

Well, it would have been better to put that into a separate bug, since it was not in rtp.c, but I've committed the fix anyway. Thanks!
By: Russell Bryant (russell) 2005-04-05 02:01:08

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:29:34.000-0600

Repository: asterisk
Revision: 5322

U   trunk/rtp.c

------------------------------------------------------------------------
r5322 | markster | 2008-01-15 15:29:34 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix RTP checksums config option (bug ASTERISK-3818 with minor mods)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5322
By: Digium Subversion (svnbot) 2008-01-15 15:29:48.000-0600

Repository: asterisk
Revision: 5338

U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r5338 | kpfleming | 2008-01-15 15:29:47 -0600 (Tue, 15 Jan 2008) | 2 lines

Allow chan_iax2 to build on systems that don't define SO_NO_CHECK (bug ASTERISK-3818, round 2)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5338
By: Digium Subversion (svnbot) 2008-01-15 15:30:39.000-0600

Repository: asterisk
Revision: 5397

U   branches/v1-0/CHANGES
U   branches/v1-0/rtp.c

------------------------------------------------------------------------
r5397 | russell | 2008-01-15 15:30:38 -0600 (Tue, 15 Jan 2008) | 2 lines

fix rtpchecksums option (bug ASTERISK-3818)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5397