Summary: | ASTERISK-03813: cdr_custom fails to load and stops Asterisk starting | ||
Reporter: | Tony Mountifield (softins) | Labels: | |
Date Opened: | 2005-03-31 03:18:37.000-0600 | Date Closed: | 2005-03-31 21:55:55.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) customload.txt | |
Description: | In cdr_custom.c, load_config() always returns -1, because res is initialized to -1 and never changed. This causes load_module() to fail and prevents Asterisk starting. | ||
Comments: | By: Olle Johansson (oej) 2005-03-31 04:27:14.000-0600 Test this patch, please. By: Tony Mountifield (softins) 2005-03-31 04:54:13.000-0600 Patch appears to work fine - thanks! By: Tony Mountifield (softins) 2005-03-31 05:14:19.000-0600 Just noticed one thing though: when ${CDR(clid}} is expanded, nothing is done to protect " characters, e.g. ""Tony Mountifield" <2000>","2000","2001","from-sip-internal","SIP/2000-a992","SIP/2001-ae71","Dial","SIP/2001|10","2005-03-31 11:52:50","2005-03-31 11:52:50","2005-03-31 11:52:50","4","2","ANSWERED","DOCUMENTATION","","1112266370.0","" cdr_csv doubles any " characters within fields. By: Olle Johansson (oej) 2005-03-31 08:09:54.000-0600 Ok, disclaimer on file for this patch. The other problem requires another bug report :-) By: Kevin P. Fleming (kpfleming) 2005-03-31 09:52:31.000-0600 Ugh, the late night fix was broken... a fix will be committed shortly. The other changes in this patch should go into a separate bug (and use English spelling <G>). By: Mark Spencer (markster) 2005-03-31 10:02:52.000-0600 Fixed in CVS head, thanks! By: Olle Johansson (oej) 2005-03-31 10:32:45.000-0600 Markster, did you even look at my patch? I added some extra warnings in there that I still think is useful. By: Kevin P. Fleming (kpfleming) 2005-03-31 13:40:09.000-0600 I'm putting the warning message changes into a separate commit, will go in shortly. By: Kevin P. Fleming (kpfleming) 2005-03-31 21:54:36.000-0600 Config warnings also added to CVS, thanks! By: Kevin P. Fleming (kpfleming) 2005-03-31 21:55:55.000-0600 Not for stable |