Summary:	ASTERISK-03809: [patch] Caller Unable to mute themselves in meetme room
Reporter:	jas_williams (jas_williams)	Labels:
Date Opened:	2005-03-30 06:37:50.000-0600	Date Closed:	2008-01-15 15:30:08.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) meetme.diff ( 1) Meetme-s-error-verbose.txt ( 2) starfix.txt
Description:	When in a meetme room with entry options set as exten => 8600,1,Meetme(1234,s) when in the room if I press * from a sip device it gets hung up with this error WARNING[18014]: app_meetme.c:1085 conf_run: Error setting conference
Comments:	By: Michael Jerris (mikej) 2005-03-30 07:05:27.000-0600 I have seen this same issue from zap clients.  I will try to pull together some debug info but this behavior makes meetme unable to take any calls for me until a full * restart, so I will have to do it after hours.  I also see this in cvs from 3/29/05. By: Michael Jerris (mikej) 2005-03-30 07:48:38.000-0600 attatched Meetme-s-error-verbose.txt.  File includes verbose output from logging into a meetme and hitting s.  Second half of the file shows what happens if I try to log back in to the same meetme before doing an * restart.  I have not done any debug on this yet but as somone else was posting it I figured I at least could post some verbose. jas_williams, please read bug guidelines and post appropriate debug. By: jas_williams (jas_williams) 2005-03-30 08:07:35.000-0600 My verbose debug output shows no more information than the error I have included in the description. By: kuj (kuj) 2005-03-30 11:03:56.000-0600 I mentioned this problem as part of the discussion in ASTERISK-3519. I think when Mark put in some changes to periodically flush the conference, some of the changes broke the star menu for me as well. What fixed things for me was to back out two of the ioctl's that were being performed in Mark's flushing fix. (See starfix.txt for the diff). Not sure what the intent of the ioctl blocks is/was, and whether they should be corrected instead of removed from the code, though. (Disclaimer on file) edited on: 03-30-05 12:10 By: jas_williams (jas_williams) 2005-03-31 03:01:48.000-0600 The starfix.txt patch does make the star menu work on my system not sure what marks changes in the original code were trying to do but removing those lines does make the star menu work correctly Jason By: Tony Mountifield (softins) 2005-03-31 08:28:11.000-0600 Yes. It's the calls to ZT_SETCONF that were added in app_meetme.c 1.84 that are failing: http://lists.digium.com/pipermail/asterisk-cvs/2005-March/005438.html Zaptel is returning EINVAL because ztc.confmode is zero but ztc.confno is non-zero. Zeroing ztc.confno for the first call and restoring it from conf->zapconf for the second call fixes that error, but then the mute/unmute menu options still don't work, because at the time they are being applied, the caller is not in a Zaptel conference. I think the mute/unmute operations should just set user->adminflags, as there are other long-standing errors in the confflags logic there too. In any case, I think it is wrong to change CONFFLAG_MONITOR and CONFFLAG_TALKER in confflags on the fly, as they should always reflect whether 'm' or 't' flags were given to MeetMe. Additionally, setting adminflags would allow the actual confmode setting to be done in the other part of the loop where adminflags is checked for changes. Unfortunately, I don't have time right now to come up with a tested patch for this. Maybe in a day or two if no-one else does. By: Anthony Minessale (anthm) 2005-03-31 14:32:25.000-0600 Try meetme.diff (Disclaimer on file) By: Tony Mountifield (softins) 2005-03-31 15:49:03.000-0600 Don't have time to try this till tomorrow, but I suspect that the mute/unmute operations (press '1') still won't work because they try to operate on a (temporarily) non-conferenced channel. By: jas_williams (jas_williams) 2005-04-01 04:22:08.000-0600 Anthm the patch seems to work fine. Jason By: Michael Jerris (mikej) 2005-04-01 12:16:00.000-0600 patch works.  No side effects seen. By: Tony Mountifield (softins) 2005-04-02 09:46:13.000-0600 Yes, I can confirm it works. The concern I expressed in my last bugnote doesn't apply, because in fact the ZT_SETCONF that changes the mute status puts the caller straight back into the conference. By: Kevin P. Fleming (kpfleming) 2005-04-02 17:33:34.000-0600 Committed to CVS, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:30:08.000-0600 Repository: asterisk Revision: 5362 U   trunk/apps/app_meetme.c ------------------------------------------------------------------------ r5362 | kpfleming | 2008-01-15 15:30:08 -0600 (Tue, 15 Jan 2008) | 2 lines Resolve app_meetme crash when member tries to mute/unmute (bug ASTERISK-3809) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5362