Summary:ASTERISK-03804: [patch] make format_sln default to write .raw files
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2005-03-29 16:38:32.000-0600Date Closed:2008-01-15 15:29:26.000-0600
Versions:Frequency of
Environment:Attachments:( 0) file.c.diff
( 1) sln.diff
Description:format_sln currently supports 2 extensions .raw and .sln but when you write it always uses .sln which makes it harded to covert the files with sox unless you rename it to .raw so this patch just reverses that, there should be no ill side-effects to this.


Disclaimer on file
Comments:By: Kevin P. Fleming (kpfleming) 2005-03-29 21:54:45.000-0600

No ill side-effects, except anyone using tools/scripts to manipulate files recorded by Asterisk using this module will have to change them :-)

By: Mark Spencer (markster) 2005-03-29 22:32:13.000-0600

Discussed with anthm....  He just needed to use another argument to sox.

By: Anthony Minessale (anthm) 2005-03-30 07:12:41.000-0600

Just to have the last word, I am the one who submitted this file to CVS to begin with, and all the patch did was reverse the default name it used to write files, either way it still supports both formats interchangably so fine don't change it but as the author of the file , i know its not all that hard of a file but still, That is my opinion.

By: Anthony Minessale (anthm) 2005-03-30 07:13:13.000-0600

I'll close it again, having had the last word.

By: Anthony Minessale (anthm) 2005-03-30 09:26:23.000-0600

ok come to think of it, I dont think the system should use a different extension other than the one you ask for.

Currently if I make an attempt to record file.raw it creates file.sln against my will.  This patch will use the extension you ask for as long as the format driver says it supports the requested format.

edited on: 03-30-05 09:28

By: Kevin P. Fleming (kpfleming) 2005-03-30 21:31:05.000-0600

That makes sense; for those cases where an extension is not supplied, it will continue to use the default it always had, but if you ask for a specific extension then you get it.

By: Mark Spencer (markster) 2005-03-30 21:32:26.000-0600

Great idea!

By: Russell Bryant (russell) 2005-04-05 01:54:34

not included in 1.0, since it's a new feature

By: Digium Subversion (svnbot) 2008-01-15 15:29:26.000-0600

Repository: asterisk
Revision: 5312

U   trunk/file.c

r5312 | markster | 2008-01-15 15:29:26 -0600 (Tue, 15 Jan 2008) | 2 lines

Use requested extension (bug ASTERISK-3804)