[Home]

Summary:ASTERISK-03797: [patch] syslog facility in logger.c is not chosen correctly
Reporter:cbachman (cbachman)Labels:
Date Opened:2005-03-28 14:31:39.000-0600Date Closed:2008-01-15 15:30:46.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch
( 1) patch.diff.txt
Description:logger.c make_logchannel uses sizeof instead of strlen when it loops through the list of available facilities to find an available match.  As a result, it will not match the correct facility.
Comments:By: Clod Patry (junky) 2005-03-28 14:34:32.000-0600

Try to attach patch as a .diff.txt extension please.
Thanks.
By: cbachman (cbachman) 2005-03-28 14:42:33.000-0600

Sorry about that, I have renamed and re-uploaded the diff.
By: Mark Spencer (markster) 2005-03-28 15:04:39.000-0600

In the future please read the bug guidelines before placing bugs, especially with respect to the "Severity".

The patch does not appear to apply to CVS, but in any case it should be irrelevant since I believe the correct fix is to simply do a strncasecmp.  If that does not take care of it, let me know.
By: Russell Bryant (russell) 2005-04-05 05:19:45

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:29:11.000-0600

Repository: asterisk
Revision: 5294

U   trunk/logger.c

------------------------------------------------------------------------
r5294 | markster | 2008-01-15 15:29:10 -0600 (Tue, 15 Jan 2008) | 2 lines

No need for sizeof (bug ASTERISK-3797)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5294
By: Digium Subversion (svnbot) 2008-01-15 15:30:46.000-0600

Repository: asterisk
Revision: 5405

U   branches/v1-0/logger.c

------------------------------------------------------------------------
r5405 | russell | 2008-01-15 15:30:45 -0600 (Tue, 15 Jan 2008) | 2 lines

silly sizeof ... (bug ASTERISK-3797)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5405