Summary:ASTERISK-03791: [patch] Add E option to the Dial command to explicitely disable echo cancellation
Reporter:Edwin Groothuis (mavetju)Labels:
Date Opened:2005-03-28 04:44:28.000-0600Date Closed:2011-06-07 14:04:45
Versions:Frequency of
Environment:Attachments:( 0) patch-apps::app_dial.c
Description:While debugging one of the fax machines here, I wondered if it was echo cancellation which ruined the transmission. With this extension to Dial, you can explicitely disable echo cancellation when you dial a number.


Disclaimer on file etc
Comments:By: Kevin P. Fleming (kpfleming) 2005-03-28 11:56:35.000-0600

New features will not be added to the stable series, so please recreate your patch against CVS HEAD.

Also, it may not be safe to call the ast_channel_setoption function on channels that don't support that option; look at app_queue to see how it decides whether to call it or not based on the channel type.

By: Mark Spencer (markster) 2005-03-29 00:42:09.000-0600

We should probably not have to have special checks...

By: Kevin P. Fleming (kpfleming) 2005-03-31 14:51:09.000-0600

Actually, it is not necessary to special case ast_channel_setoption; if the channel doesn't implement it, then it will be ignored. If the channel provides the function, but doesn't recognize the option requested, it should be ignored (unless the code in a particular channel is buggy).

So, there is no need to worry about the channel type, but your patch will need to be re-created against CVS HEAD if you wish it to be incorporated.

By: wsandiford (wsandiford) 2005-04-21 15:31:51

Has this died?  I hope not :)

By: () 2005-04-21 17:37:33

I'll work together a CVS patch in a few hours

By: Clod Patry (junky) 2005-05-09 23:54:17

Any news here?


By: Edwin Groothuis (mavetju) 2005-05-12 21:03:29

There is something wrong with this feature: When doing it on a PRI to PRI connection, I get these warnings:

May 13 11:20:33 WARNING[9354]: chan_zap.c:1254 zt_disable_ec: Unable to disable echo cancellation on channel 63
May 13 11:20:33 WARNING[9354]: chan_zap.c:1047 conf_add: Failed to add 81 to conference 9/217
May 13 11:20:33 WARNING[9354]: chan_zap.c:1047 conf_add: Failed to add 81 to conference 9/217

and the connection is dead after that.

By: Edwin Groothuis (mavetju) 2005-05-12 21:27:53

Let me explain it better:

This option works for SIP -> PRI connections.
This option fails for PRI -> PRI connections.

By: wsandiford (wsandiford) 2005-05-13 09:37:20

Has anyone been able to create this patch for HEAD yet?

By: Olle Johansson (oej) 2005-06-05 17:05:58

Still no working patch?
Should we give up and close the issue until we have a patch, then re-open. It's been sleeping for a while.


By: Clod Patry (junky) 2005-06-09 18:05:23

Instead of:
+ } else {
+ tmp->disableechocan = 0;
+ }

why not initizaling
disableechocan = 0; in the struct?

By: wsandiford (wsandiford) 2005-06-24 10:27:42

Can anyone re-write this patch for HEAD.  I could really use it

By: Michael Jerris (mikej) 2005-06-24 10:36:22

As no one has been able to produce a proper patch for head, and no response in over a month, I am suspending this bug.  If you are able to create a patch for head, feel free to re-open this bug to proceed.  Thanks.