| Summary: | ASTERISK-03737: [patch] Implement fax detection within i4l | ||
| Reporter: | David Woodhouse (dwmw2) | Labels: | |
| Date Opened: | 2005-03-22 08:12:18.000-0600 | Date Closed: | 2008-01-15 15:28:45.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) fax-detect.patch ( 1) modem-i4l-fax-detect.patch.txt | |
| Description: | Three problems. 1. Channel drivers (in particular i4l in my case) don't enable DSP_FEATURE_FAX_DETECT. I don't know if we really want to have to do this in every driver, or if we should do it somewhere generic -- or indeed if I've missed a config option I should have set to enable it. 2. The Background() application doesn't abort if a fax tone is detected. 3. Once we fix #2, ast_pbx_run() treats the 'f' return as an error. With the three trivial patches against today's CVS (attached as one file), I now have fax detection working and correctly passing through immediately to the 'f' extension. ****** ADDITIONAL INFORMATION ****** Disclaimer faxed at 14:00 UTC today 2005-03-22. It's probably not required for a patch as trivial as this, but since I'm offended by the lack of IPv6 support, there'll probably be more to come... | ||
| Comments: | By: Mark Spencer (markster) 2005-03-22 18:11:33.000-0600 Look at a correct implementation of fax in chan_zap. It is supposed to do an async_goto, not get passed up to PBX. By: David Woodhouse (dwmw2) 2005-03-22 19:14:52.000-0600 Something like that? By: Mark Spencer (markster) 2005-03-26 01:18:10.000-0600 Perfect, thanks! By: Russell Bryant (russell) 2005-04-02 10:30:06.000-0600 not included in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:28:45.000-0600 Repository: asterisk Revision: 5265 U trunk/channels/chan_modem_i4l.c U trunk/include/asterisk/vmodem.h ------------------------------------------------------------------------ r5265 | markster | 2008-01-15 15:28:45 -0600 (Tue, 15 Jan 2008) | 2 lines Implement fax detect within i4l (bug ASTERISK-3737) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5265 | ||