[Home]

Summary:ASTERISK-03694: [patch] Beginning of voice prompts chopped off
Reporter:jsnader (jsnader)Labels:
Date Opened:2005-03-17 14:37:48.000-0600Date Closed:2008-01-15 15:29:37.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) vm-patch-head
Description:We are using Asterisk with Aastra 390 phones, which have display screens and soft keys.  During the voicemail logon/password/status routines the beginning of the voice prompt is chopped off, presumably because the voice playback is started before the switch back to adsi_voice_mode can complete.  I fixed this by adding a one tenth second delay at the end of adsi_logon, adsi_password, and adsi_status.

****** ADDITIONAL INFORMATION ******

The copyright release was faxed from NetWolves management on 3/17/05.
Comments:By: Olle Johansson (oej) 2005-03-17 14:52:23.000-0600

Would it make sense to move the sleep to adsi_transmit_message?
By: Brian West (bkw918) 2005-03-17 15:11:32.000-0600

You insert a wait like we all do.

/b
By: Brian West (bkw918) 2005-03-17 15:12:19.000-0600

Also remove your initials from the comments... excess comments that serve no purpose don't need to really be there.

/b
By: Kevin P. Fleming (kpfleming) 2005-03-17 15:15:38.000-0600

Yeah, it looks like adding a small delay to adsi_transmit_message would be cleaner and cover every possible case.
By: Mark Spencer (markster) 2005-03-17 16:07:47.000-0600

Also it should use ast_safe_sleep(chan, 100).  Thanks!
By: Brian West (bkw918) 2005-03-17 21:44:06.000-0600

Please update as per the notes... ASAP please.

/b
By: jsnader (jsnader) 2005-03-18 09:55:57.000-0600

Revised patch to reflect feedback notes.  This patch is against version 1.0.4 (CVS Tag Nv1-0-4).
By: jsnader (jsnader) 2005-03-18 09:58:44.000-0600

Oops, sorry.  I generated the patch as new->old instead of old->new.  Let me know by feedback if you want a new patch.
By: Michael Jerris (mikej) 2005-03-18 10:07:07.000-0600

Please attatch diff -u patch against current head, as per bug guidelines.
By: jsnader (jsnader) 2005-03-18 10:44:34.000-0600

Redid patch against CVS HEAD as requested.  The new patch is vm-patch-head.  The bug guidelines say to delete old patches, but I don't see anyway to do that.
By: Michael Jerris (mikej) 2005-03-18 11:57:12.000-0600

Do you only need the most recent one?
By: jsnader (jsnader) 2005-03-18 12:11:53.000-0600

MikeJ,
Yes.  Only vm-patch-head is needed; the rest can be deleted.
By: Mark Spencer (markster) 2005-03-20 01:37:08.000-0600

Fixed in CVS head, thanks!
By: Russell Bryant (russell) 2005-03-31 16:27:00.000-0600

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:28:02.000-0600

Repository: asterisk
Revision: 5214

U   trunk/res/res_adsi.c

------------------------------------------------------------------------
r5214 | markster | 2008-01-15 15:28:01 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix chopping of voice prompts (bug ASTERISK-3694)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5214
By: Digium Subversion (svnbot) 2008-01-15 15:29:37.000-0600

Repository: asterisk
Revision: 5325

U   branches/v1-0/res/res_adsi.c

------------------------------------------------------------------------
r5325 | russell | 2008-01-15 15:29:36 -0600 (Tue, 15 Jan 2008) | 2 lines

fix chopping off of prompts (bug ASTERISK-3694)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5325