Summary:ASTERISK-03659: [patch] Should be able to turn off queue_log
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2005-03-09 15:27:45.000-0600Date Closed:2005-03-27 23:47:30.000-0600
Versions:Frequency of
Environment:Attachments:( 0) 20050309__queue_log_opt.diff.txt
Description:The files queue_log and event_log are created and appended to for all installations.  These options allow the creation of these logfiles to be skipped.


Disclaimer on file.
Comments:By: Mark Spencer (markster) 2005-03-10 02:41:25.000-0600

Why does this use bitfields?  It can probably just use ints since there's really only two of them.  Alternatively you could use the ast_flags structure.

By: Tilghman Lesher (tilghman) 2005-03-10 08:49:14.000-0600

We use bitfields to indicate to future programmers that we only care about the true/false value.  If someone wanted to change the usage of those flags, they'd have to change the storage structure, which would further disambiguate their purpose.

By: Kevin P. Fleming (kpfleming) 2005-03-10 11:53:47.000-0600

Looks reasonable to me.

By: Mark Spencer (markster) 2005-03-11 02:49:37.000-0600

Patch looks fine to me.  I've used it to demo the new patch subsystem.

By: Mark Spencer (markster) 2005-03-11 02:54:16.000-0600

Added to CVS.  Thanks.

By: Russell Bryant (russell) 2005-03-27 23:47:30.000-0600

not included in 1.0