[Home]

Summary:ASTERISK-03652: Unable to compile chan_h323
Reporter:Paul Belanger (pabelanger)Labels:
Date Opened:2005-03-08 12:07:59.000-0600Date Closed:2005-03-09 10:54:32.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_h323.diff
Description:Have been using chan_h323 for a while, dependancies all installed.

Updating to latest CVS HEAD I cannot complete build.

# cd /usr/local/src/asterisk
# make update
# make clean
# cd channels/h323
# make
# cd /usr/local/src/asterisk
# make

errors see Additional Information


****** ADDITIONAL INFORMATION ******

chan_h323.c: In function `oh323_new':
chan_h323.c:791: error: `tmp' undeclared (first use in this function)
chan_h323.c:791: error: (Each undeclared identifier is reported only once
chan_h323.c:791: error: for each function it appears in.)
chan_h323.c: In function `description':
chan_h323.c:2224: warning: return discards qualifiers from pointer target type
make[1]: *** [chan_h323.o] Error 1
make[1]: Leaving directory `/usr/local/src/asterisk/channels'
make: *** [subdirs] Error 1
Comments:By: Paul Belanger (pabelanger) 2005-03-08 12:15:37.000-0600

Forgot to mention:

root@gateway:~# uname -a
Linux gateway 2.4.26 ASTERISK-2 Mon Jun 14 19:07:27 PDT 2004 i686 unknown unknown GNU/Linux
By: Paul Belanger (pabelanger) 2005-03-08 12:23:05.000-0600

Looks like changes ~4/5 days ago may have broke it.

http://asterisk.espia-net.net/horde/chora/diff.php/asterisk/channels/chan_h323.c?login=2&r1=1.103&r2=1.104&ty=h
By: srathje (srathje) 2005-03-08 14:03:39.000-0600

I believe this should do the trick:

Index: asterisk/channels/chan_h323.c
===================================================================
RCS file: /usr/cvsroot/asterisk/channels/chan_h323.c,v
retrieving revision 1.104
diff -u -r1.104 chan_h323.c
--- asterisk/channels/chan_h323.c 4 Mar 2005 06:47:24 -0000 1.104
+++ asterisk/channels/chan_h323.c 5 Mar 2005 11:15:49 -0000
@@ -788,7 +788,7 @@
ast_update_use_count();
ast_mutex_lock(&pvt->lock);
if (ch) {
- tmp->tech = &oh323_tech;
+ ch->tech = &oh323_tech;
snprintf(ch->name, sizeof(ch->name), "H323/%s", host);
ch->nativeformats = pvt->capability;
if (!ch->nativeformats) {
@@ -2221,7 +2221,7 @@

char *description()
{
- return desc;
+ return (char *) desc;
}

char *key()
By: twisted (twisted) 2005-03-08 15:23:52.000-0600

This appears to be the breakpoint for this...  Can someone confirm that this proposed patch indeed fixes the problem?  Also, srathje, can you please submit this patch as an actual attachment to the bug?

Thanks!
By: Clod Patry (junky) 2005-03-08 17:00:47.000-0600

I think its due to work in struct channel (See ASTERISK-3494 for more infos).
Since is had effects on chan_sip and chan_zap, but nothing in chan_h323, i suspect that change.
By: srathje (srathje) 2005-03-08 17:06:24.000-0600

woops.. sorry.

Compiled cleanly on CVS-HEAD-03/08/05-23:55:09 (GMT+1)

Disclaimer will be faxed later today...
By: twisted (twisted) 2005-03-08 17:11:17.000-0600

No problem. I'm reluctant to commit w/o disclaimer, but since it's a little fix I'll go ahead and do it.. Just make sure you follow up when your disclaimer is on file.
By: twisted (twisted) 2005-03-08 17:15:08.000-0600

Fixed in CVS, thanks!
By: srathje (srathje) 2005-03-09 07:33:11.000-0600

Reminder sent to twisted

Disclaimer successfully submitted by fax.

Regards
Soren Rathje