Summary:ASTERISK-03637: breaks 401 invite authentication
Reporter:dweber (dweber)Labels:
Date Opened:2005-03-06 23:44:48.000-0600Date Closed:2011-06-07 14:10:14
Versions:Frequency of
Environment:Attachments:( 0) patch-wwwauth
Description:While helping a client, I scanned through chan_sip.c and found that it was failing with cvs head to do invite authentication, but not stable.  The issue is that in do_proxy_auth its ignoring the header variable.  So lets say we get a 401 and its trying to do search for Proxy-Authentication, its clearly going to break.
Comments:By: dweber (dweber) 2005-03-06 23:50:32.000-0600

Patch is in the public domain.

edited on: 03-06-05 23:53

By: maik (maik) 2005-03-07 00:26:40.000-0600

1. You obviously did not read the guidelines.
2. Your patch seems to be against a very old version of CVS.
3. It looks like this has already been fixed.

edited on: 03-07-05 00:31

By: maik (maik) 2005-03-07 00:45:47.000-0600

After having another look I think that this is a patch against the old 'stable' tree.

By: dweber (dweber) 2005-03-07 07:37:05.000-0600

Hmm, maybe you are right

edited on: 03-07-05 07:38

By: maik (maik) 2005-03-07 07:43:24.000-0600

diff -u -r1.292.2.27 chan_sip.c
--- channels/chan_sip.c 22 Apr 2004 00:50:10 -0000
+++ channels/chan_sip.c 7 Mar 2005 04:42:39 -0000

No way! The latest revision of chan_sip.c is 1.671!

By: Kevin P. Fleming (kpfleming) 2005-03-07 15:31:15.000-0600

This is not a major bug, please re-read the bug posting guidelines.

By: Mark Spencer (markster) 2005-03-08 02:09:17.000-0600

Appears not to be a bug in CVS head.

By: Russell Bryant (russell) 2005-03-11 01:56:24.000-0600

It sounds like you were using the old v1-0_stable branch or whatever it was called.  Feel free to re-open if this is still a problem in the current 1.0 branch.