[Home]

Summary:ASTERISK-03615: [patch] ENUm and DNS docs
Reporter:Olle Johansson (oej)Labels:
Date Opened:2005-03-01 16:06:15.000-0600Date Closed:2011-06-07 14:05:22
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dnscomments.txt
Description:* Adds doxygen docs for Enum and DNS routines
* Adds comments in the source
* A small fix in the txt callback function

Disclaimer on file

****** ADDITIONAL INFORMATION ******

Not for CVS stable
Comments:By: Kevin P. Fleming (kpfleming) 2005-03-01 16:51:55.000-0600

You have a major bug in there... you are calling sizeof(c->txt), but c->txt is a char *, not a char[]. sizeof is going to return 4, not the size of the buffer that c->txt is pointing to. This code is very unsafe, because it is being passed a pointer to a buffer of unknown size.

(Actually, that bug was in the original code, but probably shouldn't be fixed in this patch, because noone will ever look for a code change in a "comments" bug in Mantis if they are trying to find the source of a change).
By: Mark Spencer (markster) 2005-03-01 23:19:59.000-0600

Added to CVS head.  Thanks!
By: Olle Johansson (oej) 2005-03-02 00:32:21.000-0600

kpfleming: Thank you for spotting that. It did not change the behaviour though, but needs to be fixed. Later today.
By: Olle Johansson (oej) 2005-03-02 01:52:19.000-0600

This part is being fixed in another bug.
By: Digium Subversion (svnbot) 2008-01-15 15:26:36.000-0600

Repository: asterisk
Revision: 5115

U   trunk/dns.c
U   trunk/enum.c
U   trunk/include/asterisk/dns.h
U   trunk/include/asterisk/enum.h

------------------------------------------------------------------------
r5115 | markster | 2008-01-15 15:26:36 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix ENUM documentation (bug ASTERISK-3615)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5115