[Home]

Summary:ASTERISK-03609: chan_phone phone_send_textreports wrong error code
Reporter:matti (matti)Labels:
Date Opened:2005-03-01 06:13:16.000-0600Date Closed:2008-01-15 15:26:37.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) diff
Description:chan_phone.c function phone_send_text reports wrong error code: the text length in bytes instead of 0 on success; less than text length on error.

****** ADDITIONAL INFORMATION ******

The fix is to replace the line
return phone_write_buf(ast->pvt->pvt, text, length, length);
with
return phone_write_buf(ast->pvt->pvt, text, length, length) == length ? 0 : -1;
Comments:By: Clod Patry (junky) 2005-03-01 06:34:51.000-0600

Please attach your patch as a diff -u format.
Also, please indicates which CVS-HEAD version, the current?

Thanks.
By: matti (matti) 2005-03-01 09:09:32.000-0600

It is in the current CVS HEAD.
By: Mark Spencer (markster) 2005-03-01 23:45:22.000-0600

Fixed in CVS head.  Thanks!
By: Russell Bryant (russell) 2005-03-07 03:10:16.000-0600

that function isn't in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:26:37.000-0600

Repository: asterisk
Revision: 5116

U   trunk/channels/chan_phone.c

------------------------------------------------------------------------
r5116 | markster | 2008-01-15 15:26:37 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix chan_phone error code (bug ASTERISK-3609)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5116