[Home]

Summary:ASTERISK-03582: [patch] allow asterisk to compile on gcc4
Reporter:goatmilk (goatmilk)Labels:
Date Opened:2005-02-24 23:13:34.000-0600Date Closed:2008-01-15 15:26:06.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asteriskgcc4.patch.txt
Description:Only minor code changes in channels/ code.  Problems where function used prior to being declared static.  Several places where functions were prototyped inside other functions that caused issues.  May want to check to make sure I have not changed something important.

****** ADDITIONAL INFORMATION ******

Disclaimed.  This is my first asterisk patch.

Checked with gcc 3.3.3 and 3.4.3 to confirm the patch does not break them, and it does not.
Comments:By: Kevin P. Fleming (kpfleming) 2005-02-25 06:43:25.000-0600

I only see two changes in your patch (not several), but they seem perfectly safe.
By: Mark Spencer (markster) 2005-02-25 11:34:19.000-0600

Fixed in CVS head.  Thanks!
By: Russell Bryant (russell) 2005-02-25 12:17:19.000-0600

fixed in 1.0 - will be in 1.0.6

Next time, feel free to add a patch for the stable branch as well for an extra karma point.  :)
By: Digium Subversion (svnbot) 2008-01-15 15:26:03.000-0600

Repository: asterisk
Revision: 5076

U   trunk/channels/chan_modem_bestdata.c
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r5076 | markster | 2008-01-15 15:26:03 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix GCC 4.0 build (bug ASTERISK-3582)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5076
By: Digium Subversion (svnbot) 2008-01-15 15:26:06.000-0600

Repository: asterisk
Revision: 5079

U   branches/v1-0/channels/chan_modem_bestdata.c
U   branches/v1-0/channels/chan_zap.c

------------------------------------------------------------------------
r5079 | russell | 2008-01-15 15:26:05 -0600 (Tue, 15 Jan 2008) | 2 lines

move function prototypes outside of functions to compile under gcc4 (bug ASTERISK-3582)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5079