Summary:ASTERISK-03579: [patch] Generic Events System
Reporter:pquerna (pquerna)Labels:
Date Opened:2005-02-24 19:01:40.000-0600Date Closed:2011-06-07 14:04:52
Versions:Frequency of
Environment:Attachments:( 0) generic_events.patch
( 1) generic_events-1.txt
Description:This is a patch we've created to generalize subscribing to events to make it easier for multiple devices to be notified of state changes.

This is for notifications of off-hook, voice-mail, etc. and allow any channel to listen for other channels events.  We use it for things like call presence and voice-mail with the sip phones.  The system is generic enough to be used with any other channel types, not just SIP.


This patch is a back port into the mainline of our own tree which includes ast-data.  The original work was an improvement of the message waiting patch for ast-data and added the generic notification system to support call presence.  If you are interested in the ast-data version please ask.
Comments:By: Olle Johansson (oej) 2005-02-25 07:12:19.000-0600

Please read the bug guidelines - we need to know if this patch is disclaimed or not.

Thank you for contributing!

By: Olle Johansson (oej) 2005-02-25 07:16:44.000-0600

I find this interesting, a few comments though:

* Read code guidelines - no // comments

* Have you read and understood the current event notification system?

From a quick reading, your new architecture doesn't use the hints, which are really powerful...

I don't think we need two event notification systems within the PBX...

By: Brian West (bkw918) 2005-02-27 16:10:38.000-0600

An event notification system is very handy.  anthm did write one that would let you register the events you wished to see.  For example you could register to receive all hangup events and exec code every time it happens.  This was just one example where an external loadable module could use such a system.  Needless to say it rotted away and it was rejected.


By: Clod Patry (junky) 2005-02-27 17:16:35.000-0600

And just a small addition, if you could attach patch as a .diff.txt format, that would be appreciated by all windows user.

By: Kevin P. Fleming (kpfleming) 2005-03-03 15:33:43.000-0600

This code cannot be disclaimed, it uses rb.c which is GPL licensed by the FSF.

By: pquerna (pquerna) 2005-03-03 15:36:31.000-0600

While this implementation might have issues, can it be agreed that a generic event system of some kind is needed?  Something that could also handle Manager Events...

By: Brian West (bkw918) 2005-03-03 15:40:11.000-0600

I think we can agree that is a good idea.

By: Kevin P. Fleming (kpfleming) 2005-03-10 11:46:10.000-0600

Yes, it is a good idea, and I've been thinking about this for a few days and I believe I have a prototype in mind that everyone will be happy with...

pquerna, are you comfortable if I use parts of your code in a new alterative implementation?

By: Olle Johansson (oej) 2005-03-17 07:25:29.000-0600

Since this code is not disclaimed and not able to integrate, I think we should close this bug and open a new one when we have another solution, right?

By: Kevin P. Fleming (kpfleming) 2005-03-17 09:15:54.000-0600

Yes, I will open a new one when the system I've been working on has passed initial screening on asterisk-dev.