Summary:ASTERISK-03576: [patch] app_queue should reset timeout when wait_for_answer() finds busy
Reporter:k3v (k3v)Labels:
Date Opened:2005-02-24 15:46:21.000-0600Date Closed:2008-01-15 15:26:53.000-0600
Versions:Frequency of
Environment:Attachments:( 0) queue-timeout-reset.patch.txt
( 1) queue-timeoutrestart-optional.patch.txt

timeout is 15 seconds.
member 1 is called, but rejects the call (busy) after 10 seconds.
member 2 is called with the remainder of timeout, and only has 5 seconds left to answer.

This patch restores the timer before calling ring_one().


disclaimer on file
Comments:By: Mark Spencer (markster) 2005-02-24 18:39:39.000-0600

Why do you think this should be its behavior?  Why should a device take 10 seconds to decide that it's busy?

By: Kevin P. Fleming (kpfleming) 2005-02-24 20:12:53.000-0600

It's the user doing this, not the device. Some phones (including Polycom SIP) have a "Reject" feature available that sends "486 Busy Here" back as the response to a pending INVITE.

By: k3v (k3v) 2005-02-24 22:54:13.000-0600

wait_for_answer() re-calls ring_one() on a number of conditions that may occur after the initial ring_one() called by try_calling().  If these present without
delay, then the timeout isn't an issue.  

In my case, it is exactly as kpfleming stated.  My users may reject a call if they're not ready, and the next member should have the full opportunity to answer.

By: Mark Spencer (markster) 2005-02-25 13:08:49.000-0600

If anything this should be an option, I would think, definitely not the default behavior.

By: k3v (k3v) 2005-02-26 00:28:04.000-0600

I have attached a patch using a queues.conf option.  What scenario do you see where the timer should not reset when the next member is dialed?

By: Mark Spencer (markster) 2005-03-03 19:03:02.000-0600

Added to CVS with documentation and minor fixes, thanks!

By: Russell Bryant (russell) 2005-03-11 00:49:58.000-0600

This fix isn't being included in 1.0 since technically, it's a new feature.

By: Digium Subversion (svnbot) 2008-01-15 15:26:53.000-0600

Repository: asterisk
Revision: 5135

U   trunk/apps/app_queue.c
U   trunk/configs/queues.conf.sample

r5135 | markster | 2008-01-15 15:26:52 -0600 (Tue, 15 Jan 2008) | 2 lines

Add timeoutrestart option (bug ASTERISK-3576)