Summary:	ASTERISK-03571: [patch] Dialstring fix
Reporter:	Olle Johansson (oej)	Labels:
Date Opened:	2005-02-23 10:34:19.000-0600	Date Closed:	2011-06-07 14:05:15
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Core/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) dialstring.txt ( 1) dialstring2.txt ( 2) dialstring3.txt ( 3) extenfix.txt
Description:	The dialstring dial(SIP/user@hostname/exten) is broken. This patch fixes that. It is broken BOTH in cvs head and stable. Disclaimer on file ****** ADDITIONAL INFORMATION ****** Discovered during Astricon Training ;-)
Comments:	By: Kevin P. Fleming (kpfleming) 2005-02-23 10:39:15.000-0600 Wrong patch... this is the global qualify patch. By: twisted (twisted) 2005-02-23 10:54:20.000-0600 Actually, it's both.  Oej, please separate your patches ;) By: Kevin P. Fleming (kpfleming) 2005-02-23 10:59:37.000-0600 Well, actually his documentation is wrong, because I don't think including a secret in the dial string works anyway... it has never worked when I've tried it. By: Olle Johansson (oej) 2005-02-23 15:32:15.000-0600 Oh that's evil, I'll upload another patch. Yes, Kevin, it works... By: Olle Johansson (oej) 2005-02-23 15:40:44.000-0600 Teaches my not to upload patches during training... I'll check the auth part, but at least we can include the extension now, like sip/<username>@<hostname>/extension By: Olle Johansson (oej) 2005-02-23 16:19:41.000-0600 Try this patch, it adds the user part properly, cleans up the source a bit and properly parses and uses the username in the From: header. Kevin, you are right, the password is not there. I will see if I can add that later to make it more compatible with IAX2 dial strings (and my docs :-) ) By: Kevin P. Fleming (kpfleming) 2005-02-24 00:35:49.000-0600 Looks good to me, except for those nasty C++ commented lines :-) By: Olle Johansson (oej) 2005-02-24 01:25:05.000-0600 Yes, It's not meant for CVS yet, but I still like feedback. The first patch "extenfix.txt" is ready for CVS in order to fix the missing exten. I'll look into adding secret, since I like to have an application that follows the documentation ;-) Also, I find having the secret in the dialstring useful. By: Olle Johansson (oej) 2005-03-10 23:54:38.000-0600 Hey, nothing happening here... /Housekeeping :-) By: Olle Johansson (oej) 2005-03-19 16:00:12.000-0600 Here's a new patch. The password etc is taken care of by the SIP realm auth patch. By: Olle Johansson (oej) 2005-03-25 03:14:16.000-0600 Waking up, I see what Mark meant. I always changed the caller id, which was bad. This version changes caller ID only if we have an additional exten. Also now supports the ugly   SIP/user@domain@hostname/exten Like   SIP/oej@edvina.net@fwd.pulver.com/333388 "Dial From oej@edvina.net to 3333888@fwd.pulver.com" By: Olle Johansson (oej) 2005-03-25 13:33:06.000-0600 Will re-open after easter-leave... By: Olle Johansson (oej) 2005-05-04 02:59:20 Oops, easter is way gone. Wake up, bug reporter. By: Olle Johansson (oej) 2005-05-04 03:01:00 :-) By: Kevin P. Fleming (kpfleming) 2005-05-04 13:07:54 So what's the status here? By: Olle Johansson (oej) 2005-05-04 15:17:11 Sleeping reporter that hasn't updated the patch. Someone reminded me that I closed this earlier and had forgotten about it. So I reopened not to forget it. By: Olle Johansson (oej) 2005-06-05 17:31:32 Sorry, no time to fix this before Astricon. Will re-open as tradition bids.