Summary:ASTERISK-03540: [patch] add manager events for various parked call events
Reporter:Christopher L. Wade (clwade)Labels:
Date Opened:2005-02-18 10:34:22.000-0600Date Closed:2008-01-15 15:26:12.000-0600
Versions:Frequency of
Environment:Attachments:( 0) res_features_parking_events_v3.diff.txt
( 1) res_features_parking_events.diff.txt
( 2) res_features_parking_events.diff.txt
Description:Basically this patch adds several new manager events for equivalent * events related to parked calls.  The new events pertain mostly to status changes in calls already parked.

The events added by this patch are ParkedCallTimeOut for whenever a parked call times out, ParkedCallGiveUp for whenever a parked call hangs up, and UnParkedCall for whenever a parked call is unparked.

NOTE:  These events may not be placed/timed correctly in the various parking related functions of res_features.c.  They work for me, but I would feel better if a guru verified my placement of the events.  The basic idea of this feature request is to have parking generate a LOT more manager events.  I know that this could probably be done with some dialplan logic, but manager events just seem more logical.


I use these extra events with a manager application to monitor the status of parked calls.  This application updates a database which is later used to create an XML call pickup screen for my Cisco 7940 phones.  This allows us to replicate the 'hay <insert name of person> you have a call on line <insert number here>' of our old pbx instead of having to perform a transfer - which I'm still training my users on.
Comments:By: silik0n (silik0n) 2005-02-18 13:26:43.000-0600

Patch fails against clean head as of 1326EST 2/18/05 using patch -p0

By: Christopher L. Wade (clwade) 2005-02-18 14:36:05.000-0600

Try again, don't know what happened.  Both versions were created using 'cvs diff -u' and I just tried this last one using 'patch -p0 < patchfile' and it worked.  If it still doesn't work for you, let me know and I'll try again.  By the way, this is pretty much the first time I've tried uploading a patch, all my previous stuff has been posted on the lists or was a complete app_<blah>.c so I might be doing this wrong.

edited on: 02-18-05 14:39

By: Mark Spencer (markster) 2005-02-19 10:39:52.000-0600

Also what's your disclaimer status?

By: Christopher L. Wade (clwade) 2005-02-19 12:48:24.000-0600

will fax it in monday, sorry about not mentioning that.  is everything ok as far as this patch working as intended?

By: Mark Spencer (markster) 2005-02-19 15:10:33.000-0600

I might put "<unknown>" instead of "" in the unknown case, but i think that's arguable.

By: Mark Spencer (markster) 2005-02-19 15:14:57.000-0600

Looks like in channel.c we do use "<unknown>" so I would probably think this should match.  Let me know when your disclaimer is in!

By: Christopher L. Wade (clwade) 2005-02-21 12:55:51.000-0600

just faxed my disclaimer, should be on its way.

By: Christopher L. Wade (clwade) 2005-02-21 15:58:11.000-0600

mark, the v3 patch changes the unknown callerid stuff from "" to "<unknown>" per your suggestion.

ps, did you receive the disclaimer?

By: Christopher L. Wade (clwade) 2005-02-23 11:11:48.000-0600

any updates on this?  did you receive my disclaimer?  i'd love to see this go into CVS as its such a small change.  no big deal though, i've got my patch file, I just don't want to keep having to sync it up all the time.

By: Mark Spencer (markster) 2005-02-26 01:56:44.000-0600

Added to CVS, thanks!  We did get your disclaimer.  Sorry I've been in Miami and just now am really getting into the tracker in earnest.

By: Russell Bryant (russell) 2005-02-26 12:27:20.000-0600

not included in 1.0 since it is a new feature

By: Digium Subversion (svnbot) 2008-01-15 15:26:12.000-0600

Repository: asterisk
Revision: 5087

U   trunk/res/res_features.c

r5087 | markster | 2008-01-15 15:26:12 -0600 (Tue, 15 Jan 2008) | 2 lines

Add additional parking events (bug ASTERISK-3540)