| Summary: | ASTERISK-03525: [patch] rework of retrieve_file() for ODBC VM Storage | ||
| Reporter: | silik0n (silik0n) | Labels: | |
| Date Opened: | 2005-02-15 17:16:00.000-0600 | Date Closed: | 2008-01-15 15:25:27.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_voicemail |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) vm-odbc-cleanup.patch.txt ( 1) VMPatch2.diff | |
| Description: | Rework for the way retrieve_file() creates the temporary file used for the mmap. This corrects proper recording length guessing, removes a for loop for creating that proper length file for an mmap. ****** ADDITIONAL INFORMATION ****** disclaimer on file | ||
| Comments: | By: Kevin P. Fleming (kpfleming) 2005-02-15 18:21:10.000-0600 Some minor nitpicks: - you don't need "char *np = 0", just pass NULL to SQLGetData - same goes for "size_t bytes", you can just pass in a constant 1 and compare the result to 1 - I would lseek to fdlen-1, so that you don't end up adding a zero byte to the end of the retrieved data Otherwise looks like a nice improvement, should be much faster and require less disk space. By: silik0n (silik0n) 2005-02-15 18:43:55.000-0600 Changes a few things as per kpflemings suggestions. VMPatch2.diff is the new version By: Mark Spencer (markster) 2005-02-15 21:46:28.000-0600 Fixed in CVS head. Thanks! By: Digium Subversion (svnbot) 2008-01-15 15:25:27.000-0600 Repository: asterisk Revision: 5035 U trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r5035 | markster | 2008-01-15 15:25:27 -0600 (Tue, 15 Jan 2008) | 2 lines Optimize vm storage (bug ASTERISK-3525) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=5035 | ||