|Summary:||ASTERISK-03516: [patch] distinctive ring detection with Caller ID/Australia.|
|Date Opened:||2005-02-15 01:56:46.000-0600||Date Closed:||2006-05-17 11:53:11|
|Environment:||Attachments:||( 0) bug-3596.patch|
|Description:||Bug ASTERISK-1001 created a patch for Distinctive ring detection after CID (for Australians). I was hoping that this patch would have made it into asterisk - but unfortunately it hasnt yet.|
I did add comments to 1007 after it was closed, hoping that it would be reopened and added to the code, but I guess I didnt get noticed. Any chance this could be added to the code?
I have a current patch, which I applied to asterisk 1.0.5, which works a treat if you need it...
|Comments:||By: Mark Spencer (markster) 2005-02-15 23:45:37.000-0600|
Just post a patch for CVS head, no point doing one for stable.
By: deon (deon) 2005-02-16 05:06:50.000-0600
Attached is the original patch as from bug ASTERISK-1001 - I just applied it to CVS and it applied OK.
I cant take credit for writing it !
edited on: 02-27-05 22:13
By: deon (deon) 2005-02-16 05:09:18.000-0600
Sorry, delete bug1007.txt - its not the right file...
The correct diff is bug1007.diff
By: Clod Patry (junky) 2005-02-27 22:20:21.000-0600
Like twisted closed ASTERISK-1001 due to lack of interest, if no one demonstrates interest for that bug, i think no one demonstrates interest for the current bug, which is a "copy" of ASTERISK-1001.
Maybe if some Telstra's users wants to focus on that problem, that would really good, otherwise, we'll close that bug too.
p.s. When attaching patches, attach them as a .diff.txt format for windows users.
Thanks for understanding.
By: deon (deon) 2005-02-27 23:09:01.000-0600
I'm interested in it? I'm I not enough? I can test it!
By: Olle Johansson (oej) 2005-03-17 08:31:08.000-0600
Ok, no activity again. We have no disclaimer for this patch as far as I can see, so we can't apply it. Find the original authors, make them all send in a disclaimer and confirm on the bug tracker. Read the bug guidelines for more information.
We need activity to move patches forward.
By: deon (deon) 2005-03-21 02:37:49.000-0600
OK, should I treat this as a bug then?
Somebody made this patch because Asterisk does not recognise the distinctive ring when the phone service has distinctive ring and caller ID enabled.
Without this patch, asterisk does not work with distinctive ring in Australia. (Unless - I THINK - caller ID detection is disabled - pointless huh?)
I would write this patch, but I dont know c++ - looking at the code it looks very straight forward? If you want me to say that I'm an author, then lets do that?
By: Olle Johansson (oej) 2005-03-21 03:10:28.000-0600
Ok, took a deeper look into this bug report. Since this is not your patch and since the patch 1007 was not disclaimed, we can't accept this patch for CVS, sorry.
One way forward is to find the original author, ask him to disclaim his patch, then clean it up according to the comments in ASTERISK-1001.
If you have any other questions, find a bug marshal in #asterisk-bugs on IRC.
By: Michael Jerris (mikej) 2005-05-02 07:57:52
veejoe: Do you have a disclaimer on file? If not could you please fill out the disclaimer from bugs.digium.com so we can get this patch in.
By: Michael Jerris (mikej) 2005-05-25 21:34:10
Closed due to inactivity. Please reopen this bug when there is disclaimed code to be reviwed. If you are unable to write a patch, please contract with an asterisk consultant or post a bounty on the wiki.
By: deon (deon) 2006-01-21 20:27:33.000-0600
I'm reopening this bug to attach the latest diff - if it doesnt attach I'll open a new ticket, so that others who want this feature, can use this patch.
I was using this patch for 1.2.1 without any issues, and just applied it to 1.2.2 as well.
BTW: I wish this feature would be added to asterisk. Australia gets the Distinct Ring after CID, so this patch enables Distinctive Ring detection to work if you have both features enabled on your phone.
If anybody is intereted in this patch, then send me an email, and I'll let the developers know about the interest...
By: Gonz (gs) 2006-02-04 16:04:45.000-0600
I've manually applied this patch to chan_zap.c on Asterisk 1.2.4 (by looking at the diff and making the changes in the right places, as it doesn't apply cleanly) and I've gotten much further with a similar distinctive ring problem as described in this bug. What happened in my case is that Asterisk would show:
-- Starting simple switch on 'Zap/1-1'
.. and immediately after:
-- Detected ring pattern: 0,0,0
It didn't wait a few seconds to detect the ring pattern. I figured maybe the problem is the same as with Australia (distinctive ring after CID) so I looked into this patch. I'm actually in Argentina, but I figured maybe it's the same case as with AU's telephone system. Now it looks a lot better (as it waits 3 seconds before making a decision on the detected ring pattern), but the problem is that the detected ring pattern is the same for the main number as for the second number:
-- Starting simple switch on 'Zap/1-1'
-- Detecting post-CID distinctive ring
Feb 4 19:42:38 NOTICE: chan_zap.c:6129 ss_thread: Got event 18 (Ring Begin)...
-- Detected ring pattern: 197,0,0
-- Checking 197,0,0
It ALWAYS detects 197,0,0 except for one attempt where it detected a different pattern for the main number, but in 99% of cases its 197,0,0. Is there some way I can make it wait a second longer to determine the ring pattern? Any suggestions?
Thanks! If anybody wants this patch for 1.2.4, let me know and I'll upload the diff. I take no credit for the code, of course, I simply adapted it to 1.2.4.
By: Dave Bowerman (dbowerman) 2006-02-09 01:46:15.000-0600
I'll take this on to get it resolved. (reproduce the patch against svn trunk, and disclaim the code).
It also needs testing against analog pots ports on ISDN Home / ISDN2 enhanced and analog spectrum services in Australia. I'll do this also.
Please leave the bug open for a few days.
By: Dave Bowerman (dbowerman) 2006-02-11 21:29:02.000-0600
Re-coded the patch against svn trunk R9644. The patch file is bug-3596.patch above.
The disclaimer is on its way.
By: deon (deon) 2006-02-12 13:35:32.000-0600
awesome! I'll test it for you...
By: deon (deon) 2006-02-28 03:05:55.000-0600
Tested, and patch works perfectly... :)
By: Hadley Rich (hads) 2006-03-23 15:57:31.000-0600
Patch is necessary and works well in New Zealand.
By: macka (macka) 2006-04-05 07:52:48
Thanks for the patch DBowerman, can you please get the disclaimers in so that the patch can make it's way downstream?
By: Serge Vecher (serge-v) 2006-05-04 10:05:18
dbowerman: can you please confirm that you've sent the disclaimer so that we can get your patch in?
By: Dave Bowerman (dbowerman) 2006-05-04 20:16:27
disclaimer was posted via snail-mail in february.
By: Serge Vecher (serge-v) 2006-05-05 08:49:35
patch bug-3596.patch still applies to zaptel trunk 1022. Marking this 'confirmed' as there are successful reports from users.
By: Joshua C. Colp (jcolp) 2006-05-17 11:53:09
This is in trunk as of revision 27812. Thanks everyone for holding on this long! PEACE!