[Home]

Summary:ASTERISK-03499: [patch] Agent hangup during announcement is broken
Reporter:mhaigh (mhaigh)Labels:
Date Opened:2005-02-13 07:47:49.000-0600Date Closed:2008-01-15 15:25:13.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.patch
Description:The behaviour of app_queue.c in the latest CVS is broken in the event that the agent hangs up while being played the announce message or being told the customer hold time (ie: the agent has picked up and acknowledged but has not yet been connected to the caller).

Current behaviour results in the customer call being terminated in an ugly way.  The reason is that the customer channel is being checked for hangup rather than the agent channel.  The return code of -1 also seems odd, since I would expect we want to just keep the customer first in the queue rather than dropping them.

The attached patch seems to make everything the way I expect.  I don't _think_ anything's broken in the process.
Comments:By: nick (nick) 2005-02-13 08:41:24.000-0600

Do you have a disclaimer on file?

Nick
By: Kevin P. Fleming (kpfleming) 2005-02-13 10:50:46.000-0600

This does appear to be the correct fix, and since it's only a two-liner it is probably safe to merge without a disclaimer :-)
By: Mark Spencer (markster) 2005-02-13 10:54:19.000-0600

Should be fixed in CVS.  The patch you attached was not quite appropriate, but I think the changes I made should be correct.  If you continue to have trouble with CVS head, feel free to reopen.  Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:25:13.000-0600

Repository: asterisk
Revision: 5018

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r5018 | markster | 2008-01-15 15:25:12 -0600 (Tue, 15 Jan 2008) | 2 lines

Properly differentiate between caller and agent hangups (bug ASTERISK-3499)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5018