[Home]

Summary:ASTERISK-03413: [patch] app_meetme fails to send audio
Reporter:constfilin (constfilin)Labels:
Date Opened:2005-02-01 19:23:23.000-0600Date Closed:2008-01-15 15:24:02.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.diff
Description:greetings -

I the CVS version of app_meetme.c on line 909 starts a long if/else if
branch that goes like this:

if ((f->frametype == AST_FRAME_VOICE) && (f->subclass == AST_FORMAT_SLINEAR)) {
...
}
else if (...) {
...
}
else if (...) {
...
}
else if (using_pseudo) {
   if (f->frametype == AST_FRAME_VOICE) { // line 1062
      if (f->subclass == AST_FORMAT_SLINEAR) { // line 1063
         // line 1064 is never reached
      }
}

But the code never reaches line 1064 because if the conditions on line 1062
and 1063 are true then the code must have gotten into the if condition on
line 909.

The result is that there is no conference.

The attached patch fixes the problem


****** ADDITIONAL INFORMATION ******

My disclaimer is on file with Digium.
Comments:By: constfilin (constfilin) 2005-02-01 19:31:11.000-0600

Sorry, I uploaded an unworking patch. The new patch compiles and works all right. Also, I should have called this "[patch] app_meetme fails to send audio"
By: Mark Spencer (markster) 2005-02-01 20:19:19.000-0600

Fixed in CVS head, thanks!
By: Russell Bryant (russell) 2005-02-06 21:30:20.000-0600

issue only in head
By: Digium Subversion (svnbot) 2008-01-15 15:24:02.000-0600

Repository: asterisk
Revision: 4947

U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r4947 | markster | 2008-01-15 15:24:01 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix conferencing of non-zap stuff (bug ASTERISK-3413)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4947