[Home]

Summary:ASTERISK-03411: non-numerical calleridnum can't be presented
Reporter:mcisse (mcisse)Labels:
Date Opened:2005-02-01 09:58:36.000-0600Date Closed:2008-01-15 15:24:31.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/Interoperability
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When trying to set calleridnum to a non numerical value, it doesn't work. Normal, you'll say.
But I've some stupid phones that will present only NUM from "NAME" <sip:NUM@IP>. NAME is ignored by the phone.
So, I'd like to be able to present non-numerical values (names) using NUM.
When trying to set a numerical calleridnum, it is replaced by the default callerid.


The "problem" is line 3730 of chan_sip.c (CVS HEAD):
if (!l || !ast_isphonenumber(l))
 l = default_callerid;

Personally, I've replaced it by:
if ((!l || !ast_isphonenumber(l)) && *default_callerid!=0)
 l = default_callerid;

Comments:By: Mark Spencer (markster) 2005-02-01 13:24:29.000-0600

Okies fixed in CVS.
By: Russell Bryant (russell) 2005-02-06 21:24:52.000-0600

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:23:59.000-0600

Repository: asterisk
Revision: 4944

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r4944 | markster | 2008-01-15 15:23:58 -0600 (Tue, 15 Jan 2008) | 2 lines

Only use default callerid if it's specified (bug ASTERISK-3411)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4944
By: Digium Subversion (svnbot) 2008-01-15 15:24:31.000-0600

Repository: asterisk
Revision: 4972

U   branches/v1-0/channels/chan_sip.c

------------------------------------------------------------------------
r4972 | russell | 2008-01-15 15:24:30 -0600 (Tue, 15 Jan 2008) | 2 lines

only use default cid if specified (bug ASTERISK-3411)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4972