Summary: | ASTERISK-03404: segmentaion fault in app_meetme.c | ||
Reporter: | constfilin (constfilin) | Labels: | |
Date Opened: | 2005-02-01 00:20:36.000-0600 | Date Closed: | 2008-01-15 15:23:57.000-0600 |
Priority: | Critical | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_meetme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_meetme.diff | |
Description: | The current app_meetme.c goes only halfway to try working when a pseudo zap channel can't be created. In this case "build_conf" initializes conf->fd and leave conf->chan equal NULL. Then in conf_run annoucement about user joining or leaving the conference are still played on conf->chan, which is NULL. This creates segmentation fault. The attached patch checks for conf->chan being not NULL before passing it to ast_streamfile(). This is not a full solution to haveing meetme work when Zap pseudo channel is not available but is it better than having a segmentation fault. Would be great to have this in CVS. ****** ADDITIONAL INFORMATION ****** I ran cvs diff on the leatest version of app_meetme.c (1.75) | ||
Comments: | By: Mark Spencer (markster) 2005-02-01 00:47:52.000-0600 Fixed in CVS head. Next time please use cvs diff -u format, and if you remember to mention your disclaimer you'll get an extra +1 of karma! Thanks! By: Russell Bryant (russell) 2005-02-06 21:16:38.000-0600 feature not in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:23:57.000-0600 Repository: asterisk Revision: 4942 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r4942 | markster | 2008-01-15 15:23:56 -0600 (Tue, 15 Jan 2008) | 2 lines Fix potential segfault (bug ASTERISK-3404) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4942 |