[Home]

Summary:ASTERISK-03381: [patch] manager hold events
Reporter:k3v (k3v)Labels:
Date Opened:2005-01-29 15:06:29.000-0600Date Closed:2008-01-15 15:25:05.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip-hold-events.patch.txt
( 1) sip-hold-events-flagify.patch.txt
( 2) sip-hold-events-HEAD20050129.patch.txt
Description:Generate events Hold and Unhold when chan_sip turns on or off the MOH.  Enabled with per-peer option 'holdevents'.

****** ADDITIONAL INFORMATION ******

Disclaimer on file.
Comments:By: silik0n (silik0n) 2005-01-29 16:57:37.000-0600

Hunk 3 Fails to apply to head
By: k3v (k3v) 2005-01-29 17:11:41.000-0600

My cvs ver is a week old, and chan_sip changes a lot. :)  I'll check out current head and re-diff shortly.
By: Mark Spencer (markster) 2005-01-29 17:17:25.000-0600

Added to CVS with minor cleanups (and changed the name to "callevents" in case we want to do events for transfer, etc as well).
By: Kevin P. Fleming (kpfleming) 2005-01-29 17:34:19.000-0600

Shouldn't p->onhold be a flag in p->flags instead of an int all by itself?
By: k3v (k3v) 2005-01-29 17:35:29.000-0600

Are flags used for state info, or just for config options?
By: Kevin P. Fleming (kpfleming) 2005-01-29 17:49:01.000-0600

They are used for pretty much everything, see all the SIP_ flags at the top of the file. Some of the state related ones would be NEEDDESTROY, REALTIME, etc.
By: k3v (k3v) 2005-01-29 17:53:34.000-0600

mark, want me to flagify this?  I'm not up to speed on flags, aren't we limited to 32 of em?

edited on: 01-29-05 17:55
By: Mark Spencer (markster) 2005-01-29 21:10:00.000-0600

Flagify is good, yes we are limited to 32...
By: Mark Spencer (markster) 2005-01-29 21:10:34.000-0600

Be sure your patch is against CVS head which already contains the first part, thanks!
By: k3v (k3v) 2005-01-29 22:08:02.000-0600

roger.  I'll drop off a new patch in a few days.
By: Mark Spencer (markster) 2005-02-04 01:18:52.000-0600

Any luck or should I just close this one out?
By: k3v (k3v) 2005-02-04 23:07:37.000-0600

My wife had emergency surgery last weekend.  I'm behind with everything.  I'll get this by Tuesday.
By: k3v (k3v) 2005-02-09 00:45:17.000-0600

flagified against tonight's CVS.  functions.
By: Paul Cadach (pcadach) 2005-02-09 16:45:08.000-0600

Is it possible to add
 ast_queue_control(ast_bridged_channel(p->owner), AST_CONTROL_HOLD);
and
 ast_queue_control(ast_bridged_channel(p->owner), AST_CONTROL_UNHOLD);
to transmit notification to calling party about channel is get held?
By: k3v (k3v) 2005-02-09 17:41:30.000-0600

I didn't know that was committed yet.  Sure, I can add that.  Give me til Thurs though.
By: Paul Cadach (pcadach) 2005-02-09 17:46:08.000-0600

There was ASTERISK-1815 which added hold notification support for PRI channels.
By: Mark Spencer (markster) 2005-02-10 00:37:08.000-0600

To clarify, you do *not* queue on the bridged channel, you queue on the channel that you normally would queue any other event on.
By: k3v (k3v) 2005-02-11 13:37:32.000-0600

I'm going to leave this feature request alone.  PCadach, feel free to patch it in per mark's guidelines.  

Mark, if you're ready to commit, I don't have any more to add.
By: Digium Subversion (svnbot) 2008-01-15 15:23:39.000-0600

Repository: asterisk
Revision: 4921

U   trunk/channels/chan_sip.c
U   trunk/configs/sip.conf.sample

------------------------------------------------------------------------
r4921 | markster | 2008-01-15 15:23:39 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge callevents etc (bug ASTERISK-3381)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4921
By: Digium Subversion (svnbot) 2008-01-15 15:25:05.000-0600

Repository: asterisk
Revision: 5010

U   trunk/Makefile
U   trunk/asterisk.c
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r5010 | markster | 2008-01-15 15:25:05 -0600 (Tue, 15 Jan 2008) | 2 lines

Flagify hold (bug ASTERISK-3381)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5010