|Summary:||ASTERISK-03371: [patch] - RealTime Extensions gets segfault when using res_config_mysql|
|Date Opened:||2005-01-28 12:04:24.000-0600||Date Closed:||2005-01-29 00:21:22.000-0600|
|Environment:||Attachments:||( 0) res_config_mysql_v1.7.txt|
|Description:||As reported to me by George K., asterisk seg faults when using RealTime MySQL v1.5.1 (CVS 1.6) with RealTime Extensions.|
I found the problem and fixed it. Yea for me.
The patch also tries to bring my version numbers into sync with CVS numbers. My version 1.5.1 is listed as 1.6 in CVS so I'm guessing that if this patch gets committed it will become CVS 1.7
|Comments:||By: Mark Spencer (markster) 2005-01-28 15:08:20.000-0600|
1) This patch does not apply to CVS
2) The category name MUST be the first entry of the first requested column (see res_config_odbc). Thanks!
By: drmac (drmac) 2005-01-28 15:34:21.000-0600
1. I don't see how it doesn't apply to cvs. I just co'd a fresh copy (v1.6 on CVS: --- res_config_mysql.c 27 Jan 2005 02:55:26 -0000 1.6)
and did 'patch -p0 <res_config_mysql_v1.7.txt' and it worked.
2. There are only 2 instances of the word "ast_category_new" in odbc. The first instance makes a new category with "" as the name. The second uses the category name from db.
There are only 2 instances in mysql. First is the same as odbc (just in a different location to skip computations if no memory is alloc'd). Second is the same.
By: Mark Spencer (markster) 2005-01-28 16:40:41.000-0600
1) It still didn't apply for me but I manually made the change.
2) You're right, since my version, it was changed to create the category and then do a rename. This will preclude us from having more efficient category storage but clearly wasn't your fault and if it's going to be fixed it will have to be fixed elsewhere as well.