Summary: | ASTERISK-03370: INFO dmtf processing doesn't handle A, B and C tones | ||
Reporter: | bfontana (bfontana) | Labels: | |
Date Opened: | 2005-01-27 19:21:35.000-0600 | Date Closed: | 2008-01-15 15:23:35.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) chan_sip.c ( 1) mydiff.txt | |
Description: | Function receive_info doesn't handle A,B and C dtmf tones in the right way. It ignores them completely. | ||
Comments: | By: nick (nick) 2005-01-27 20:39:09.000-0600 Uhh... not so much. RFC2833 section 3.10 states how DTMF digits are to be sent: as numbers. A-D are represented as 12-15, not by using their letter. Also, in the future, patches should be submitted in diff -u format, which you can get by running 'cvs diff -u <file>' from the root of the Asterisk source tree. You'll also need a disclaimer. Nick By: Mark Spencer (markster) 2005-01-27 21:47:34.000-0600 Fixed in CVS head. Reopen if you still have trouble. By: Russell Bryant (russell) 2005-01-29 01:14:21.000-0600 fixed in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:23:25.000-0600 Repository: asterisk Revision: 4906 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r4906 | markster | 2008-01-15 15:23:25 -0600 (Tue, 15 Jan 2008) | 2 lines Handle oddly sent 'A' to 'D' (bug ASTERISK-3370) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4906 By: Digium Subversion (svnbot) 2008-01-15 15:23:35.000-0600 Repository: asterisk Revision: 4916 U branches/v1-0/channels/chan_sip.c ------------------------------------------------------------------------ r4916 | russell | 2008-01-15 15:23:34 -0600 (Tue, 15 Jan 2008) | 2 lines handle INFO A through D (bug ASTERISK-3370) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4916 |