[Home]

Summary:ASTERISK-03337: [patch] Asterisk crashes when loading chan_modem_i4l.
Reporter:gregp (gregp)Labels:
Date Opened:2005-01-23 19:07:39.000-0600Date Closed:2008-01-15 15:23:06.000-0600
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) modem.patch.txt
Description:Asterisk crashes when trying to load chan_modem_i4l.so, when it comes across an undefined symbol AST_A2LIN:

Jan 23 19:04:24 asterisk asterisk[23925]: VERBOSE[23925]:  [chan_modem_i4l.so]
Jan 23 19:04:24 asterisk asterisk[23925]: WARNING[23925]: loader.c:302 in __load_resource: /usr/lib/asterisk/modules/chan_mod
em_i4l.so: undefined symbol: AST_A2LIN
Jan 23 19:04:24 asterisk asterisk[23925]: WARNING[23925]: loader.c:510 in load_modules: Loading module chan_modem_i4l.so fail
ed!

rm'ing the module and restarting lets it load fine, but since this module appears to be default I've filed this under 'crash'.

This is as a direct result of a commit of the patch located in bug:

http://bugs.digium.com/bug_view_page.php?bug_id=0003409

This patch is incorrect.  It should be using AST_LIN2A() where it uses AST_ALAW(), and it should be using AST_ALAW() where it currently is using the invalid AST_A2LIN().


****** ADDITIONAL INFORMATION ******

I might add that the names of these macros are slightly confusing, as one might expect AST_ALAW() to actually convert to ALAW, but it in fact does the opposite.
Comments:By: nick (nick) 2005-01-23 19:21:55.000-0600

I'll put this in "patch format" for grepp...

DOF

NB

edited on: 01-23-05 19:23
By: Brian West (bkw918) 2005-01-23 20:13:33.000-0600

ah I see
By: Mark Spencer (markster) 2005-01-23 20:57:09.000-0600

Fixed in CVS head.
By: Digium Subversion (svnbot) 2008-01-15 15:23:06.000-0600

Repository: asterisk
Revision: 4885

U   trunk/channels/chan_modem_i4l.c
U   trunk/include/asterisk/alaw.h

------------------------------------------------------------------------
r4885 | markster | 2008-01-15 15:23:05 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix chan_modem_i4l (bug ASTERISK-3337)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4885