[Home]

Summary:ASTERISK-03321: [patch] flag to record a conference pseudo channel only
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2005-01-20 22:11:20.000-0600Date Closed:2008-01-15 15:22:57.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_meetme.c_recording_rev2.txt
( 1) app_meetme.c_recording_rev3.txt
( 2) meetmehead.diff.txt
( 3) meetmestable.diff.txt
Description:This patch add a new flag 'r' which when set, it will record the conference.  You can specify the filename and format using these variables :
MEETME_RECORDINGFILE
MEETME_RECORDINGFORMAT

****** ADDITIONAL INFORMATION ******

Disclamed
Comments:By: Mark Spencer (markster) 2005-01-20 22:28:46.000-0600

This is a great idea, but needs a few cleanups in the implementation:

1) If you request the channel in "linear" format instead of ulaw, then the sounds will not sound right when you're using the builtin sounds instead of custom files.

2) The default filename should be documented.

3) "wav" would be a more reasonable default recording format :)

4) I don't see ast_closestream ever get called, this would cause a file descriptor leak...  

5) Initialization of the filestream can be omitted since you use it, and if you did want to intialize it you would set it to NULL not '\0' which will create a compiler warning.

Other than that, looks great!
By: Brian West (bkw918) 2005-01-20 22:42:41.000-0600

strdupa vs ast_strdupa?  wouldn't ulaw be the best format since the conf is already in ulaw?  Maybe have a way to exec something whent he monitoring is done so you can have the file mailed to you... similar to how Monitor can do custom args and such.

bkw
By: Brian West (bkw918) 2005-01-20 22:45:01.000-0600

MEETME_RECORD_EXEC would be handed 1 arg the file name.
MEETME_RECORD_EXEC_ARGS any addition args you want.

then exec it.

Check Monitor for an example it would be helpful ;)

bkw
By: mochouinard (mochouinard) 2005-01-20 22:54:25.000-0600

you are right ;) Ok Uploaded a new updated patch

btw twisted got the idea ;)
By: mochouinard (mochouinard) 2005-01-21 07:45:46.000-0600

uploaded new version, small little posible problem, + #define stuff so code read more easily
By: twisted (twisted) 2005-01-21 10:15:34.000-0600

yeah yeah.. I had the idea, you just made it actually work..   I still can't figure out why monitor/record won't pull data from the pseudo channel, though.  Is it safe to use pthread_create() outright and not ast_pthread_create()?
By: twisted (twisted) 2005-01-21 10:42:59.000-0600

actually, if you compile with pthread_create() you get a compiler warning,
and a symbol __use_ast_pthread_create_instead__.

edited on: 01-21-05 10:43
By: twisted (twisted) 2005-01-21 18:59:13.000-0600

I have uploaded the patch for stable, the way it should be. I will update your patch for head again tonight.
By: twisted (twisted) 2005-01-21 19:08:10.000-0600

added meetmehead.diff.txt to patch on head :)
By: Mark Spencer (markster) 2005-01-21 22:48:48.000-0600

Added to CVS, thanks!
By: Russell Bryant (russell) 2005-01-22 00:12:19.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:22:57.000-0600

Repository: asterisk
Revision: 4876

U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r4876 | markster | 2008-01-15 15:22:57 -0600 (Tue, 15 Jan 2008) | 2 lines

Add option for recording conference (bug ASTERISK-3321), thanks moc!

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4876