Summary: | ASTERISK-03294: [patch] allow to see who is talking in a conference | ||
Reporter: | mochouinard (mochouinard) | Labels: | |
Date Opened: | 2005-01-17 21:12:56.000-0600 | Date Closed: | 2008-01-15 15:23:41.000-0600 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_meetme |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) app_meetme.c_whoistalking_rev1.txt ( 1) app_meetme.c_whoistalking_rev2.txt ( 2) app_meetme.c_whoistalking_rev3.txt | |
Description: | This patch is just to test this feature from the CLI. Once this patch is applyed, you will see who is talking in the CLI ****** ADDITIONAL INFORMATION ****** Disclamed | ||
Comments: | By: mochouinard (mochouinard) 2005-01-17 21:14:29.000-0600 This patch is just an idea. If it work good, I wonder if we should add it to the 'meetme list'. I wish I could detect the DB of each channels instead, to detect background noise too. By: Mark Spencer (markster) 2005-01-17 21:14:30.000-0600 This should be an option that can be enabled or not, obviously since it causes a lot of overhead to run the dsp on all the channels! By: mochouinard (mochouinard) 2005-01-17 21:15:44.000-0600 Agree, this is just an experiment to actually see if it work, I dont know where to put this information anyway except 'meetme list' By: ckruetze (ckruetze) 2005-01-18 04:06:57.000-0600 This information would be usufull if it could be accessed through the management interface. This would allow a better management of the conference through for example a web application. It would also be useful when recording a conference and beeing able to figure out who was talking when. If only the overhead wouldn't be... Just a thought: If you detect the DB and figure out wether somebody is talking or if it is background noise, you could use this information to not merge the channels audio into the conference. This should save some processing time and maybe even reduce the noise in the conference. By: mochouinard (mochouinard) 2005-01-18 04:43:24.000-0600 Added optional flag, Manager Event, and simple digit info in meetme list By: stevekstevek (stevekstevek) 2005-01-18 09:11:55.000-0600 If you're looking for examples of this kind of thing: a) Detecting speech, b) Only mixing speakers, c) Monitoring speakers from Manager interface, See app_conference, which does all three. Unfortunately, using the VAD in ast_dsp doesn't work well enough to actually switch speech on and off, but it might be OK for what you're doing here (where false positives/negatives just mean the indications are off, and not that speech is lost). By: Mark Spencer (markster) 2005-01-19 00:04:14.000-0600 Much better :) I'll put a little more thought into it too before merging in case I think of some other ideas... By: mochouinard (mochouinard) 2005-01-19 07:35:51.000-0600 Uploaded some cleanup of the code. The only thing Im thinking right now is to store the last 10 silence time for example, so we can more accuratly evaluate the start talk to iliminage the small audio noise that a peer could be doing. But I guess this could be done outside of meetme, and maybe it would be a good idea to make that inside DSP, so other apps could use this improvement. So for the moment, I think that it for this patch. By: Mark Spencer (markster) 2005-01-29 21:05:55.000-0600 Fixed in CVS head with small mods. Thanks! By: Russell Bryant (russell) 2005-01-30 23:05:04.000-0600 not in 1.0 By: Digium Subversion (svnbot) 2008-01-15 15:23:41.000-0600 Repository: asterisk Revision: 4923 U trunk/apps/app_meetme.c ------------------------------------------------------------------------ r4923 | markster | 2008-01-15 15:23:40 -0600 (Tue, 15 Jan 2008) | 2 lines Add meetme talk detector (bug ASTERISK-3294) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=4923 |