[Home]

Summary:ASTERISK-03288: [patch] Force a make clean after cvs updates
Reporter:nick (nick)Labels:
Date Opened:2005-01-16 20:16:35.000-0600Date Closed:2008-01-15 15:22:11.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) newmrclean.patch.txt
Description:I'm just going to let this two-line patchlet out... if you want it, fine :)

All it does is force a make clean before every build, unless you 'make noclean'.  Hopefully, this will prevent bug reports and confusion when structures are changed, without too much of a burden on those who know better :)

****** ADDITIONAL INFORMATION ******

Disclaimer on File
Comments:By: twisted (twisted) 2005-01-16 20:36:59.000-0600

I don't like this approach, but after talking to nick on irc, i think we have a better solution that should be up here VERY shortly.
By: nick (nick) 2005-01-16 21:16:41.000-0600

I like this version a lot better... here's what we came up with:

The .cleanme file is checked into cvs (and thus replaced on each co or update), and the deleted by 'make clean' which is called by cleantest: in the Makefile if .cleanme exists. The noclean target still exists for the brave.

The Makefile has also been updated to remove .version file in the clean target and the README file now included information about making clean, both because twisted told me to :)

NB

edited on: 01-16-05 21:17
By: twisted (twisted) 2005-01-16 21:29:54.000-0600

looks grrd to me
By: Mark Spencer (markster) 2005-01-16 21:45:53.000-0600

It is rarely but occasionally necessary to do a make clean after a cvs update.  Perhaps there is a way I could indicate (by updating or changing a particular file) which could then indicate that a "make clean" should be performed...

For example, cleantest could do:

if ! cmp -s .cleanme .cleanmelast; then \
   make clean ; rm -f .cleanmelast ; cp -f .cleanme .cleanmelast; \
fi

What do you think?

Then all I have to do is put something new in ".cleanme" (e.g. increment a number).
By: twisted (twisted) 2005-01-16 21:47:23.000-0600

Sounds good to me, but the main reason we wanted to do this after each update is to 1) fix the version numbers for bug posts/irc help and 2) prevent internal object mismatches (happens more than one would think)
By: twisted (twisted) 2005-01-16 21:54:18.000-0600

after talking to markster a little further, I think the incremental comparason between the two would work as well, and allow us to "force" a clean when necessary.
By: nick (nick) 2005-01-16 22:22:38.000-0600

You guys sure are picky :)!  I made the files be named .cleancount and .lastclean, which makes a little more sense to me.

NB

PS I've starting looking at doing an autoconf for Asterisk... won't that be fun!
By: Mark Spencer (markster) 2005-01-16 22:45:34.000-0600

Added to CVS, thanks!
By: Russell Bryant (russell) 2005-01-17 15:03:58.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:22:11.000-0600

Repository: asterisk
Revision: 4822

_U  trunk/
A   trunk/.cleancount
U   trunk/.cvsignore
U   trunk/Makefile
U   trunk/README

------------------------------------------------------------------------
r4822 | markster | 2008-01-15 15:22:10 -0600 (Tue, 15 Jan 2008) | 2 lines

Allow me to force a "make clean ; make install" on a cvs update (bug ASTERISK-3288)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4822