[Home]

Summary:ASTERISK-03270: [patch] Fix and simplify loguniqueid, fix reload, avoid deadlock on malloc failures
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2005-01-14 09:38:43.000-0600Date Closed:2008-01-15 15:22:08.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_odbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_odbc.c.diff.txt
( 1) cdr_odbc.c.v1-0.diff.txt
Description:This patch fixes and simplifies loguniqueid, fixes cdr_odbc module reload and tries to avoid deadlock on malloc failures.

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Brian West (bkw918) 2005-01-14 09:50:39.000-0600

Leave the loguniqueid alone.. fix the problem with the malloc only please.  I like how it is.

bkw
By: Andrey S Pankov (casper) 2005-01-14 10:06:07.000-0600

Anyway the code where you parse it is wrong when e.g. "loguniqueid=no"! And why there is "loguniqueid_alloc = 1;" on malloc failure?

Why do you think calling ast_true each time when you need to store a CDR is better then call it one time on init?
By: Andrey S Pankov (casper) 2005-01-14 10:07:17.000-0600

Here is cdr_odbc.c.v1-0.diff.txt for stable to stay in sync with HEAD.
By: Brian West (bkw918) 2005-01-14 10:36:03.000-0600

I could care less at this point I don't even use cdr_odbc anymore :P

bkw
By: Mark Spencer (markster) 2005-01-15 02:58:06.000-0600

Fixed in CVS head, thanks!
By: Russell Bryant (russell) 2005-01-16 19:40:20.000-0600

fixed in 1.0

Thank you for the 1.0 patch!!
By: Digium Subversion (svnbot) 2008-01-15 15:21:48.000-0600

Repository: asterisk
Revision: 4799

U   trunk/cdr/cdr_odbc.c

------------------------------------------------------------------------
r4799 | markster | 2008-01-15 15:21:48 -0600 (Tue, 15 Jan 2008) | 2 lines

ODBC CDR fixes for bizarre error conditions and small performance improvement (bug ASTERISK-3270)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4799
By: Digium Subversion (svnbot) 2008-01-15 15:22:08.000-0600

Repository: asterisk
Revision: 4819

U   branches/v1-0/cdr/cdr_odbc.c

------------------------------------------------------------------------
r4819 | russell | 2008-01-15 15:22:08 -0600 (Tue, 15 Jan 2008) | 2 lines

various fixes (bug ASTERISK-3270)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4819