[Home]

Summary:ASTERISK-03266: [patch] zaptel no longer compiles under 2.6
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2005-01-13 13:27:20.000-0600Date Closed:2008-06-07 10:47:33
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20050113__zaptel_fix.diff.txt
( 1) 20050113__zaptel_fix.tgz
( 2) mydiff.txt
Description:/usr/src/zaptel/zaptel.c:6229: error: parse error before "int"
/usr/src/zaptel/zaptel.c:6229: warning: type defaults to `int' in declaration of `module_param'
/usr/src/zaptel/zaptel.c:6229: warning: function declaration isn't a prototype
/usr/src/zaptel/zaptel.c:6229: warning: data definition has no type or storage class
/usr/src/zaptel/zaptel.c:6230: error: parse error before "int"
/usr/src/zaptel/zaptel.c:6230: warning: type defaults to `int' in declaration of `module_param'
/usr/src/zaptel/zaptel.c:6230: warning: function declaration isn't a prototype
/usr/src/zaptel/zaptel.c:6230: warning: data definition has no type or storage class

****** ADDITIONAL INFORMATION ******

Looks like the most recent fix broke the compile.  I'm running kernel 2.6.3 and compiling with gcc version 3.3.2.
Comments:By: Mark Spencer (markster) 2005-01-13 13:42:07.000-0600

Builds fine on my Linux 2.6 box.  Is module_param not part of kernel 2.6.3?  If not, when does it disappear?
By: Tilghman Lesher (tilghman) 2005-01-13 14:46:22.000-0600

Well, it appears to be defined in /usr/src/linux-2.6.3-19mdk/include/linux/moduleparam.h, but it apparently doesn't work.
By: Tilghman Lesher (tilghman) 2005-01-13 15:28:48.000-0600

Here's one way to fix it...
By: Russell Bryant (russell) 2005-01-13 20:46:12.000-0600

-/* #define CONFIG_ZAPTEL_MMX */
+#define CONFIG_ZAPTEL_MMX

Sneakyness!  :)
By: Tilghman Lesher (tilghman) 2005-01-13 21:09:23.000-0600

Ooops, now fixed.
By: Mark Spencer (markster) 2005-01-13 21:22:35.000-0600

What do you mean it's defined but doesn't work.

It works on my box! :)
By: Tilghman Lesher (tilghman) 2005-01-13 22:03:55.000-0600

Well, the nice thing about that patch is that if your setup works with the new macro, it'll still work with that macro, and if your setup only works with the old macro, it'll still work with that old macro.  Either way, it fixes the brokenness, whereever it may be.
By: Tilghman Lesher (tilghman) 2005-01-13 22:05:51.000-0600

I suppose the alternative is to revert the last fix, as it was working with more machines than it is now.
By: Mark Spencer (markster) 2005-01-14 00:06:31.000-0600

Fixed in CVS head.
By: Russell Bryant (russell) 2005-01-16 19:56:28.000-0600

should be fixed in 1.0 now, too
By: Digium Subversion (svnbot) 2008-06-07 10:47:33

Repository: dahdi
Revision: 555

U   trunk/pciradio.c
U   trunk/tor2.c
U   trunk/torisa.c
U   trunk/wcfxo.c
U   trunk/wct1xxp.c
U   trunk/wct4xxp.c
U   trunk/wctdm.c
U   trunk/wcte11xp.c
U   trunk/zaptel.c
U   trunk/ztdummy.c
U   trunk/ztdynamic.c

------------------------------------------------------------------------
r555 | markster | 2008-06-07 10:47:32 -0500 (Sat, 07 Jun 2008) | 2 lines

Fix compile on older 2.6 kernels (bug ASTERISK-3266)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=555