[Home]

Summary:ASTERISK-03262: [patch] When group= gets error parsing, it returns 0 instead of the result.
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2005-01-12 12:14:08.000-0600Date Closed:2008-01-15 15:21:32.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/Configuration
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20050112__group_fix.diff.txt
Description:When ast_get_group() finds a non-numeric, it should ignore the unknown value and continue parsing the line, rather than cancelling all groups already parsed.

Examples:
group=1,4,o,3   ; returns 0, should return 0b11010
group=1,4,o     ; returns 0, should return 0b10010

Note that the error message was also wrong; it was NOT using bit 0; instead, it was returning no groups.

****** ADDITIONAL INFORMATION ******

Disclaimer on file
Comments:By: Mark Spencer (markster) 2005-01-12 21:27:05.000-0600

I think the error message meant it was using "0" instead of returning a mask, not setting bit 0.  Anyway clearly your your patch improves the behavior :)
By: Russell Bryant (russell) 2005-01-12 23:15:12.000-0600

fixed in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:21:25.000-0600

Repository: asterisk
Revision: 4773

U   trunk/channel.c

------------------------------------------------------------------------
r4773 | markster | 2008-01-15 15:21:25 -0600 (Tue, 15 Jan 2008) | 2 lines

Handle syntax errors in group descriptions more gracefully (bug ASTERISK-3262)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4773
By: Digium Subversion (svnbot) 2008-01-15 15:21:32.000-0600

Repository: asterisk
Revision: 4781

U   branches/v1-0/channel.c

------------------------------------------------------------------------
r4781 | russell | 2008-01-15 15:21:31 -0600 (Tue, 15 Jan 2008) | 2 lines

Handle syntax errors in group descriptions more gracefully (bug ASTERISK-3262)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4781