[Home]

Summary:ASTERISK-03256: [patch] DYNFS is not correctly set
Reporter:Michael Labuschke (zigman)Labels:
Date Opened:2005-01-11 20:58:06.000-0600Date Closed:2008-06-07 10:47:43
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) bristuff-0.2.0-RC3-fix_DYNFS_command-1.patch
( 1) bristuff-0.2.0-RC3-fix_DYNFS_command-2.patch.txt
( 2) mydiff.txt
Description:i was rebuilding my asterisk today and was supprised, that the zaptel Makefile created my /dev/zap* devices. I use udevd so it shouldn't be created.
so i checked the makefile and indeed. it should.
but my DYNFS var was emtpy, so they got created.
to make a long story short.
here is some output

root@winxp:~# cat Makefile
all:
       @echo $(shell ps ax | grep -v grep | grep init)
       @echo $(shell ps ax | grep -v grep | grep udevd)
root@winxp:~# LC_ALL=C make
1 ? S 0:01 init [3]
/bin/sh: s: No such file or directory
make: *** [all] Error 1

why did the first work and the second not?

root@winxp:~# LC_ALL=C make -n
echo     1 ?        S      0:01 init [3]
echo   865 ?        S<s    0:00 udevd

there is is.. it piping a <s

there are 2 proper fixes
the one i like more is

from zaptel-1.0.3 Makefile
ifeq (${BUILDVER},linux24)
#We only support DEVFS in linux 2.4 kernels, since its considered obsolete post 2.4
DYNFS=$(ps ax | grep -v grep | grep devfsd)
endif
ifeq (${BUILDVER},linux26)
#Tests for newer linux-2.6 udev support
DYNFS=$(ps ax | grep -v grep | grep udevd)
endif

which is just plain wrong. (at least gave me empty strings here)

either replace ps ax with  "ps axo comm" to only diplay command names. or what i did with the patch is to sed the output of ps


****** ADDITIONAL INFORMATION ******

Disclaimer is sent.
Comments:By: Michael Labuschke (zigman) 2005-01-12 21:11:41.000-0600

this patch works much better. its cleaner. putting "" arround the command is the best fix i came up with. ;) enjoy
By: twisted (twisted) 2005-01-12 23:26:25.000-0600

Interesting... cvs head is the same way, and I haven't had a single problem out of it.
By: Mark Spencer (markster) 2005-01-14 00:53:09.000-0600

Fixed in CVS head (see mydiff.txt)
By: Russell Bryant (russell) 2005-01-16 18:53:47.000-0600

fixed in 1.0
By: Digium Subversion (svnbot) 2008-06-07 10:47:43

Repository: dahdi
Revision: 561

U   branches/v1-0/Makefile

------------------------------------------------------------------------
r561 | russell | 2008-06-07 10:47:41 -0500 (Sat, 07 Jun 2008) | 2 lines

set DYNFS correctly (bug ASTERISK-3256)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=561