[Home]

Summary:ASTERISK-03228: [patch] AgentCallbackLogin problem
Reporter:tgj (tgj)Labels:
Date Opened:2005-01-09 02:46:24.000-0600Date Closed:2008-01-15 15:22:25.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.c.patch
Description:When i Login with AgentCallBackLogin the command 'show agents' will show the agent is available. the command 'show queues' will show that the agent is unavailable and will not receive calls from the queue, but if I reload asterisk, the command 'show queues' will show that the agent 'has taken no calls yet' and the agent will now receive calls from the queue.

If the agents log out and then logs in again, I will have to reload asterisk before this agent will receive calls.

Comments:By: tgj (tgj) 2005-01-09 04:10:48.000-0600

This bug also applies to CVS-HEAD-01/03/05-18:14:30
By: pjc (pjc) 2005-01-09 22:22:55.000-0600

I've run across this, too, and I think I have a fix.  Would somebody mind eyeballing this to see if I'm barking up the wrong tree?

I think the problem's in app_queue.c's changethread function:
               while(cur) {
                       if (!strcasecmp(sc->dev, cur->interface)) {
The above line compares "Agent" with "Agent/1", because sc->dev is having a null inserted at the slash to separate the technology and location strings.  I've fixed this by copying sc->dev to a temporary variable.  I'm going to attach a (fairly trivial) patch that errs on the side of avoiding side effects.  I can send a disclaimer for this, if need be.
By: tgj (tgj) 2005-01-11 07:37:14.000-0600

Hi pjc

I have applied your patch, and it works very well. Hope this will make it into the CVS.

Thank you.
thorben
By: pjc (pjc) 2005-01-14 15:15:21.000-0600

You're most welcome, thorben, glad to be able to help.

FWIW, if my logs are to be believed, I've just faxed the disclaimer in (via TxFAX, of course).
By: jmls (jmls) 2005-01-18 04:30:36.000-0600

I can also confirm that this works for me. Many thanks !
By: Mark Spencer (markster) 2005-01-18 14:40:51.000-0600

Fixed in CVS head, patch slightly modified, thanks!
By: Russell Bryant (russell) 2005-01-18 20:20:55.000-0600

don't think this is in 1.0 - let me know if it is, though
By: Digium Subversion (svnbot) 2008-01-15 15:22:25.000-0600

Repository: asterisk
Revision: 4838

U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r4838 | markster | 2008-01-15 15:22:24 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix agentcallback login (bug ASTERISK-3228)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4838