[Home]

Summary:ASTERISK-03226: [PATCH] flags conversion, formatting cleanup, minor changes
Reporter:Kevin P. Fleming (kpfleming)Labels:
Date Opened:2005-01-08 21:14:09.000-0600Date Closed:2008-01-15 15:20:42.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) moh_flags_cleanup_rev1.diff.txt
Description:The attached patch converts res_musiconhold to use the flags macros (small memory savings), cleans up the code formatting, removes extraneous casts and an unused struct field, and makes some minor changes to logic constructions and code flow to make the code clearer.

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Mark Spencer (markster) 2005-01-09 02:56:04.000-0600

Fixed in CVS except a few notes:

1) For consistancy I prefer sizeof(struct foo) to sizeof(*foo) within Asterisk, even though I can see how sizeof(*foo) is likely less prone to mistakes when programming :)

2) (int)(sizeof(foo)) is actually a required cast for printf since on some systems sizeof() can be a long and would require %ld in that case.

Thanks!
By: Russell Bryant (russell) 2005-01-09 08:55:38.000-0600

not in 1.0
By: Digium Subversion (svnbot) 2008-01-15 15:20:42.000-0600

Repository: asterisk
Revision: 4724

U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r4724 | markster | 2008-01-15 15:20:41 -0600 (Tue, 15 Jan 2008) | 2 lines

Various moh fixes (bug ASTERISK-3226)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4724