[Home]

Summary:ASTERISK-03218: [patch] Clean up to use consistent "flagification"
Reporter:Russell Bryant (russell)Labels:
Date Opened:2005-01-08 14:56:28.000-0600Date Closed:2008-01-15 15:21:04.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) flagification.rev2.txt
( 1) flagification.txt
Description:This patch changes a lot of flag operations that were already there to the flag macros in utils.h to keep things consistent throughout the code.

This also gets rid of some compiler warnings from ast_record_review in app.c.

****** ADDITIONAL INFORMATION ******

disclaimer is on file
Comments:By: Russell Bryant (russell) 2005-01-10 00:34:19.000-0600

updated to current CVS head
By: Mark Spencer (markster) 2005-01-10 08:42:39.000-0600

Fixed in CVS.  I also made the fixes to app.c the "correct" ones.  We want to use const char * wherever we reasonably can as it allows the compiler to better optimize in some cases, and it keeps people from manipulating data that they shouldn't :)

Also had to add a "nonstd" since some of the flags we're applying this to are non-unsigned int as per the protocol description.

Thanks!
By: Digium Subversion (svnbot) 2008-01-15 15:21:04.000-0600

Repository: asterisk
Revision: 4748

U   trunk/app.c
U   trunk/apps/app_dial.c
U   trunk/apps/app_forkcdr.c
U   trunk/apps/app_queue.c
U   trunk/cdr.c
U   trunk/channel.c
U   trunk/include/asterisk/app.h
U   trunk/include/asterisk/cdr.h
U   trunk/include/asterisk/channel.h
U   trunk/include/asterisk/dundi.h
U   trunk/include/asterisk/utils.h
U   trunk/pbx/pbx_dundi.c
U   trunk/res/res_features.c

------------------------------------------------------------------------
r4748 | markster | 2008-01-15 15:21:03 -0600 (Tue, 15 Jan 2008) | 2 lines

More flagification, courtesy drumkilla (bug ASTERISK-3218)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4748