[Home]

Summary:ASTERISK-03214: [patch] Change for easier MultiLanguage * setup in sounds file
Reporter:mochouinard (mochouinard)Labels:
Date Opened:2005-01-08 12:12:52.000-0600Date Closed:2011-06-07 14:04:56
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) multilang_soundschange.diff.txt
Description:This patch is to make * not to use a root language by default. So if you SetLanguage(fr) it will check file in sounds/fr/SOUNDFILEYOUREQUESTED

Also Ive modify the Makefile and * cvs struct so it support multiple languages easily by adding a folder only

****** ADDITIONAL INFORMATION ******

This patch is backward compatible, if file in new structure is not found, it will look in the old structure.

Also all the file in CVS under sounds/* will need to be moved to sounds/en/*.  If you wish to include other language, just create sounds/LANGHERE.

1 things, is I wonder if we should call the folder sounds/en-allison/ instead, so we can add different voice. And maybe make a .conf file with the alias of default request for only SetLanguage(en) to en-allison or setLanguage(fr) to fr-moc
Disclamed
Comments:By: mochouinard (mochouinard) 2005-01-08 12:13:23.000-0600

Note, currently, it forced to EN if no lang is specified
By: twisted (twisted) 2005-01-08 14:34:10.000-0600

I don't believe this behaviour should be changed.  Not because i'm an english speaker, but because english is a universal language.  If we set it to fail back to english if a) we can't find the requested language, or b) because no language is set, then we are doing the right thing.   If the language needs to be changed, it can be changed in a NUMBER of places.  Am I missing something here?
By: ckruetze (ckruetze) 2005-01-08 14:59:20.000-0600

I like the idea. It makes it more consitent accross all languages

sounds/fr for french
sounds/en for english
sounds/dk for danish
...

Not only does it look better, but it makes it easier for scripts that want to access sound files. Right now, we need to check if it is english and then handle the access different then for any other language.
Adding/removing languages would also be easier, if the sound files for one language would not be in:
sounds/xx
sounds/digits/xx
sounds/letters/xx
...

Please implement this patch.
By: Mark Spencer (markster) 2005-01-08 15:31:23.000-0600

I do not agree with changing the path. For example if the file is "/foo/bar/baz" instead of "bar/baz" we cannot simply look for "/fr/foo/bar/baz".
By: ckruetze (ckruetze) 2005-01-08 16:10:03.000-0600

What is wrong with "/fr/foo/bar/baz", to me that sounds more logic then "/foo/bar/fr/baz".
All french files would be in one place, somewhere under "sounds/fr".
By: mochouinard (mochouinard) 2005-01-08 20:47:09.000-0600

this type of structure should have being made from the start, it might be annoying to do it now, but it for the best.  Also, like might be a good idea to think of having LANGUAGE-VOICE structure, so like :
en-allison
So we can have like :
en-uk
en-us
en-us_tx
en-au
en-ca.....
Also with maybe a language.conf that define the default 'voice' for every language, and also define the SYSTEM default.

edited on: 01-08-05 20:48
By: Andrey S Pankov (casper) 2005-01-11 08:23:21.000-0600

Language related configuration can be done in asterisk.conf file:

[general]
defaultlanguage=en

[languages]
en=/var/lib/asterisk/sounds
fr=/var/lib/asterisk/sounds_fr
ru=/var/lib/asterisk/sounds_ru
By: mochouinard (mochouinard) 2005-01-17 20:06:32.000-0600

I got the feeling that even if this is desirable, it wont get into CVS !! ??
By: Mark Spencer (markster) 2005-02-08 01:54:10.000-0600

I think there are portions of this which may still be worth consideration (e.g. the idea of having sublanguages lik en-foo and en-bar) but changing the entire directory structure definitely seems like an idea that is unlikely to make it based on the discussion i've seen so far.
By: Clod Patry (junky) 2005-02-11 19:50:09.000-0600

Moc, im dealing with multi-language all day long, and i've to admit, i'm not getting your real point here.

Why not just creating a dir "fr" inside sounds/ ?
many "voice" in french?
sounds/fr/male, sounds/fr/female or sounds/male and sounds/female with file.fr or file.en inside these dir for both language?

And with casper's note, i think you can do everything you want too, no?

What's a real need for now related to that bug moc?
By: mochouinard (mochouinard) 2005-02-27 20:04:08.000-0600

The idea is to make it more standards across the board, instead of just doing something to deal with a problem we saw after.  Beable to add a language pack as a sound folder outside of the 1 sounds directory make more sence.
By: mochouinard (mochouinard) 2005-03-16 20:51:29.000-0600

Mark doesn't like this change