[Home]

Summary:ASTERISK-03200: [patch] One Touch Record Fix
Reporter:Anthony Minessale (anthm)Labels:
Date Opened:2005-01-06 19:12:23.000-0600Date Closed:2008-01-15 15:21:14.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) features_rev0.diff
( 1) features_rev1.diff
( 2) features_rev2.diff
( 3) features_rev3.diff
( 4) features_rev4.diff
( 5) features_rev5.diff
Description:This patch makes One Touch Record(tm) work a bit better.
when you activate the feautre by dialing the specified code, a subsequent keying of the same code will now stop the recording, the default filename is compsed by using a timestamp and the channels invloved and the TOUCH_MONITOR var has been switched to represent the siginificant part of the filename rather than the entire app args.

so with this patch you can start and stop several recordings in the same call and have them seperated.


****** ADDITIONAL INFORMATION ******

Disclaimer on file
anthmct@yahoo.com
Comments:By: Mark Spencer (markster) 2005-01-06 20:29:02.000-0600

what's the "path" variable used for?  and why do we snprintf into buf with sizeof(path) and why -1?  Why do we set chan1,chanb to NULL, and then check their value?
By: Brian West (bkw918) 2005-01-06 21:54:25.000-0600

As far as I can tell he does the - 1 to leave room for the \0 and chana and chanb hold a copy of the callerid for chan and peer.  Maybe they shouldn't be called chana and chanb to cut any confusion.  (You seem tired... go hop in the hot tub boi)

bkw
By: Mark Spencer (markster) 2005-01-06 23:34:25.000-0600

That doesn't apply to snprintf only to strncpy
By: Anthony Minessale (anthm) 2005-01-07 09:57:50.000-0600

here
By: Mark Spencer (markster) 2005-01-07 11:07:35.000-0600

It would be preferable to not lock both channels simultaneously since there is a small (very small) risk of a deadlock.  Thanks!
By: Anthony Minessale (anthm) 2005-01-07 11:17:38.000-0600

ok, i'll just ast_strdupa the info from chans so I dont even need to lock.
By: Olle Johansson (oej) 2005-01-07 12:44:43.000-0600

Pls add doc on variables to README.variables
By: Anthony Minessale (anthm) 2005-01-07 17:35:13.000-0600

rev4 to also support reload
By: Mark Spencer (markster) 2005-01-09 21:59:14.000-0600

Fixed in CVS head.  Thanks!
By: Anthony Minessale (anthm) 2005-01-11 11:49:46.000-0600

Another fix, I'll just add it to this existing bug.

This new patch makes sure the caller/callee is properly set.
By: cmslaght (cmslaght) 2005-01-11 12:10:45.000-0600

My users have commented that the 'beep' is annoyingly loud when a attended transfer occurs.  I also have not been able to get the 'OneTouch' record to work.  Can someone post the syntax or sample.
By: Mark Spencer (markster) 2005-01-11 12:20:10.000-0600

Fixed again in CVS.  You can always disable the beep.
By: Digium Subversion (svnbot) 2008-01-15 15:20:58.000-0600

Repository: asterisk
Revision: 4742

U   trunk/doc/README.variables
U   trunk/res/res_features.c

------------------------------------------------------------------------
r4742 | markster | 2008-01-15 15:20:58 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge Tony's one touch record improvements (bug ASTERISK-3200)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4742
By: Digium Subversion (svnbot) 2008-01-15 15:21:14.000-0600

Repository: asterisk
Revision: 4760

U   trunk/res/res_features.c

------------------------------------------------------------------------
r4760 | markster | 2008-01-15 15:21:13 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix one touch record (bug ASTERISK-3200, take two)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4760