[Home]

Summary:ASTERISK-03197: [patch] Make sure we do del any remaining connections + misc fixes
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2005-01-06 06:51:57.000-0600Date Closed:2008-01-15 15:20:57.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_mgcp.c.HEAD.diff.txt
( 1) chan_mgcp.c.HEAD.diff2.txt
Description:I don't know why nobody noticed that ASTERISK-2928 fix in HEAD is broken when in v1-0 it is not (please see http://lists.digium.com/pipermail/asterisk-cvs/2004-December/004370.html for reference). For short, transmit_connection_del(sub) is inside if (option_verbose > 2) section. Moreover, I fix here "+" line introduced with latest ASTERISK-2831 fix (not sure here, please correct me if I'm wrong) and some broken formatting.

Another question is about the construct below:
if ((c = strrchr(gname, ']')))
       *c = '\0';
Can you explain me please the semantics. Is it a pointer to "real" boolean value conversion?..

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Andrey S Pankov (casper) 2005-01-06 07:08:19.000-0600

Here is updated diff (chan_mgcp.c.HEAD.diff2.txt) with verbose/debug output fixes for distinctive ring as well.

edited on: 01-06-05 07:10
By: Andrey S Pankov (casper) 2005-01-06 07:13:20.000-0600

And in this bug I leave "the construct" mentioned above untouched :)
markster: did you just _silently_ fix my "formatting" fix in ASTERISK-3184?

edited on: 01-06-05 07:19
By: Mark Spencer (markster) 2005-01-09 18:38:40.000-0600

Fixed in CVS....  the construct you mention just removes the trailing ] from the name.
By: Digium Subversion (svnbot) 2008-01-15 15:20:57.000-0600

Repository: asterisk
Revision: 4741

U   trunk/channels/chan_mgcp.c

------------------------------------------------------------------------
r4741 | markster | 2008-01-15 15:20:57 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix MGCP when running without verbose (bug ASTERISK-3197)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4741