[Home]

Summary:ASTERISK-03196: dial not respect the t and T options
Reporter:cherso (cherso)Labels:
Date Opened:2005-01-06 05:35:07.000-0600Date Closed:2008-01-15 15:20:17.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:as you can see dialling with the option t (called transfer) the calling user is able to transfer too
same problem with option T

   -- Executing Dial("SIP/2-7886", "sip/1|120|t") in new stack
   -- Called 1
   -- SIP/1-3d73 is ringing
   -- SIP/1-3d73 answered SIP/2-7886
   -- Attempting native bridge of SIP/2-7886 and SIP/1-3d73
Jan  6 12:29:16 NOTICE[5717]: res_features.c:421 builtin_blindtransfer: XXX Blind Transfer SIP/2-7886, SIP/1-3d73 (sense=2) XXX
   -- Started music on hold, class 'default', on SIP/2-7886
   -- Playing 'pbx-transfer' (language 'it')
   -- Unable to find extension '' in context 'sip'
   -- Playing 'pbx-invalid' (language 'it')
   -- Stopped music on hold on SIP/2-7886
   -- Attempting native bridge of SIP/2-7886 and SIP/1-3d73
Jan  6 12:29:29 NOTICE[5717]: res_features.c:421 builtin_blindtransfer: XXX Blind Transfer SIP/2-7886, SIP/1-3d73 (sense=1) XXX
   -- Started music on hold, class 'default', on SIP/1-3d73
   -- Playing 'pbx-transfer' (language 'it')
   -- Unable to find extension '' in context 'sip'
   -- Playing 'pbx-invalid' (language 'it')
   -- Stopped music on hold on SIP/1-3d73
   -- Attempting native bridge of SIP/2-7886 and SIP/1-3d73
 == Spawn extension (sip, 95, 1) exited non-zero on 'SIP/2-7886'

Comments:By: cherso (cherso) 2005-01-06 05:51:17.000-0600

in app_dial.c
is this correct?

ast_set2_flag(tmp, strchr(transfer, 't'), DIAL_ALLOWREDIRECT_IN);
ast_set2_flag(tmp, strchr(transfer, 't'), DIAL_ALLOWREDIRECT_OUT);
By: Clod Patry (junky) 2005-01-06 06:03:16.000-0600

this is not a major bug related to the bug guidelines.
By: cherso (cherso) 2005-01-06 08:52:40.000-0600

well an incoming caller can transfer the call so it's a major
security issue

edited on: 01-06-05 09:53
By: cherso (cherso) 2005-01-06 08:54:17.000-0600

it's just a typo

here is the fix
ast_set2_flag(tmp, strchr(transfer, 't'), DIAL_ALLOWREDIRECT_IN);
ast_set2_flag(tmp, strchr(transfer, 'T'), DIAL_ALLOWREDIRECT_OUT);
By: Mark Spencer (markster) 2005-01-06 11:15:08.000-0600

Fixed in CVS head, thanks!
By: Russell Bryant (russell) 2005-01-06 13:36:17.000-0600

sorry about that ...
By: Digium Subversion (svnbot) 2008-01-15 15:20:17.000-0600

Repository: asterisk
Revision: 4696

U   trunk/apps/app_dial.c
U   trunk/res/res_features.c

------------------------------------------------------------------------
r4696 | markster | 2008-01-15 15:20:17 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix typo for blind transfer (bug ASTERISK-3196)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4696