[Home]

Summary:ASTERISK-03184: [patch] chan_mgcp formatting, spacing cleanups
Reporter:Andrey S Pankov (casper)Labels:
Date Opened:2005-01-05 04:10:06.000-0600Date Closed:2008-01-15 15:20:17.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_mgcp.c.HEAD.diff.txt
Description:I hope now chan_mgcp code will be [at least] readable...

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Andrey S Pankov (casper) 2005-01-05 04:13:49.000-0600

I will add here the patch for v1-0 later (after commit in HEAD).

By: alric (alric) 2005-01-05 13:46:18.000-0600

Just tested this, looks good.  Any reason this can't be committed?

By: Mark Spencer (markster) 2005-01-06 02:11:30.000-0600

Added to CVS but there was one failed chunk you might want to fix and reopen at your convenience.

By: Andrey S Pankov (casper) 2005-01-06 03:02:03.000-0600

It failed because you'd committed "bug ASTERISK-2831, with mods" before this one.. ;)
Ok, I'll fix this chunk formatting in another bug since there is a separate issue to be resolved [in HEAD only].

I reopen this one to add formatting fixes for stable branch...

edited on: 01-06-05 09:57

By: Mark Spencer (markster) 2005-01-09 04:16:43.000-0600

You can discuss patching stable with drumkilla.  I don't know if he's planning on fixing formatting things in stable.

By: Russell Bryant (russell) 2005-01-09 23:34:08.000-0600

If you want to make a patch for stable formatting, I'll be more than happy to add it.

By: Digium Subversion (svnbot) 2008-01-15 15:20:17.000-0600

Repository: asterisk
Revision: 4695

U   trunk/channels/chan_mgcp.c

------------------------------------------------------------------------
r4695 | markster | 2008-01-15 15:20:16 -0600 (Tue, 15 Jan 2008) | 2 lines

Improve MGCP formatting (bug ASTERISK-3184)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4695