Summary:ASTERISK-03180: [PATCH] "sip notify", reworked
Reporter:Kevin P. Fleming (kpfleming)Labels:
Date Opened:2005-01-04 16:46:36.000-0600Date Closed:2008-01-15 15:19:51.000-0600
Versions:Frequency of
Environment:Attachments:( 0) sip_notify_fixes_rev2.diff.txt
( 1) sip_notify_fixes_rev3.diff.txt
( 2) sip_notify_fixes_rev4.diff.txt
( 3) snom_notify.patch
Description:The attached patch is basically a rewrite of the "sip notify" facility that was put in yesterday (thanks to moc for the initial version!). The changes are:

- only load the config file on load/reload, not every time the command is issued

- move all "Via" header building into a function, instead of repeating the code for a sixth time

- support CLI completion of notify type, in addition to peer name

- only do completion of peer name when at the proper argument position

- support sending to multiple peers with a single command

- use ast_cli instead of ast_log for output that should only be sent to the console

- confirm sending of each NOTIFY to the console

- don't mark the NOTIFY messages for reliable sending, as they generally won't get a response

- check the type before allocating any sip_pvt structures, in case it's bogus


Disclaimer is on file.
Comments:By: mochouinard (mochouinard) 2005-01-04 19:06:11.000-0600

Ok tested it and it working great except a small completion problem with the notify type, it wont complete after the reboot-... if I do reboot-p<TAB> it will put reboot-

good job

By: mochouinard (mochouinard) 2005-01-04 19:29:47.000-0600

Uploaded the completion fix, and removed 2 unused variable. Let us know

By: Kevin P. Fleming (kpfleming) 2005-01-04 21:45:17.000-0600

Final rev... slight documentation change, and rename sample config entries to be easier to select via completion (and also to reflect that they don't directly reboot the phone, just ask for a "config check").

By: nick (nick) 2005-01-04 22:53:39.000-0600

snom_notify.patch adds Snom-style reboots to the config file.

Disclaimer on file (if that's even needed).

By: Mark Spencer (markster) 2005-01-04 23:00:20.000-0600

Added to CVS, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:19:51.000-0600

Repository: asterisk
Revision: 4666

U   trunk/channels/chan_sip.c
U   trunk/configs/sip_notify.conf.sample

r4666 | markster | 2008-01-15 15:19:51 -0600 (Tue, 15 Jan 2008) | 2 lines

Merge sip notify fixes (bug ASTERISK-3180)