[Home]

Summary:ASTERISK-03176: [patch] danish/german speech for SayUnixTime
Reporter:ulle22 (ulle22)Labels:
Date Opened:2005-01-04 10:36:44.000-0600Date Closed:2008-01-15 15:36:03.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) danish-sayunixtime.patch
( 1) danish-sayunixtime-v2.patch
( 2) danish-sayunixtime-v3.patch
( 3) danish-sayunixtime-v4.patch
Description:Problem saying the numbers right, was solved in say.c and working with SayNumber, but not with SayUnixTime

****** ADDITIONAL INFORMATION ******

See: http://bugs.digium.com/bug_view_page.php?bug_id=0001429 for info.
Comments:By: Mark Spencer (markster) 2005-01-04 15:15:03.000-0600

Can you supply a patch?
By: ulle22 (ulle22) 2005-01-04 15:21:27.000-0600

The one from bug id ASTERISK-1391429 is ok, an must just be corrected to the SayUnixTime (I think)

SayNumbers works ok...

- But im not sure that it just "copy & paste" ...

edited on: 01-04-05 16:30
By: nick (nick) 2005-01-04 15:43:07.000-0600

I think Mark's asking if you'll write the patch...
By: ulle22 (ulle22) 2005-01-04 15:51:15.000-0600

Ahh :-)

Not sure that I can! - I´m a rather new * user...
By: Clod Patry (junky) 2005-01-05 12:11:52.000-0600

what's the problem exactly for we can take a look and close that bug?
By: ulle22 (ulle22) 2005-01-05 15:09:50.000-0600

The bug is - since the danish and german speech, is diffrent from english - that SayUnixTime don´t work proberly with these language.

sample:
The number 123
In english: 1 hundred and 30 1
In danish & german 1 hundred 3 and 20

The number 8431
In english: 8 thousand 4 hundred and 30 1
In danish & german: 8 thousand 4 hundred 1 and 30

And that works perfectly in SayNumber, so i counted on that it was an easy ting to corect, for one who knows Asterisk - better then me :-)

rettet den: 01-06-05 07:21
By: Clod Patry (junky) 2005-01-10 21:10:00.000-0600

yes, in German, it's ein hundert dreiundzwanzig.
It's always "unitsunddozens" right or does it has some exception?
By: ckruetze (ckruetze) 2005-01-11 02:04:49.000-0600

In German it is always "units und tenth".

As in English 11 and 12 are the only exceptions to that.

edited on: 01-11-05 02:05
By: nick (nick) 2005-01-12 13:48:53.000-0600

app_sayunixtime is calling ast_say_date_with_format() using channel->language.  ast_say_date_with_format() should then be calling ast_say_date_with_format_de() if channel->language is "de".  The _de function should be saying stuff right... but if you're using latest CVS, and your channel's language is "de" (show channel <x> should confirm), and it still isn't saying stuff right, then you might just have a  bug.

Please, test and report back.

Nick
By: Frank Sautter (xylome) 2005-01-17 08:49:50.000-0600

are you shure you are using cvs-head?
my patch addressed this problem, the bug is closed and the patch is in cvs since 2004-11-14
http://bugs.digium.com/bug_view_page.php?bug_id=0002780
By: Clod Patry (junky) 2005-02-03 21:44:35.000-0600

ulle22: can ya try latest CVS and tell us if the xylome's patch fixed your problem?

Thanks.
By: ulle22 (ulle22) 2005-02-09 13:32:44.000-0600

I have just upgraded to 1.0.5, and it´s still not working proberly!

Heres the output: (Time: 20:32:19)

   -- Executing SetLanguage("SIP/101-5628", "da") in new stack
   -- Executing SayUnixTime("SIP/101-5628", "||HMS") in new stack
   -- Playing 'digits/20' (language 'da')
   -- Playing 'digits/30' (language 'da')
   -- Playing 'digits/2' (language 'da')
   -- Playing 'digits/19' (language 'da')

So now it´working from 1 to 20 but above that, is still wrong.

rettet den: 02-09-05 13:35
By: Mark Spencer (markster) 2005-02-27 18:49:59.000-0600

Does it work properly if you select "de" rather than "da"?  I see no check currently to map "da" into "de"
By: Clod Patry (junky) 2005-03-13 23:07:13.000-0600

ulle22, any feed-backs here?
can you answer to master's question?

xylome is talking about CVS-HEAD, not about stable branch.
Try it with latest cvs HEAD version please and report what's wrong exactly.

Thanks.
By: Matt O'Gorman (mogorman) 2005-03-16 13:30:00.000-0600

has this or has this not been resolved in head?
By: tgj (tgj) 2005-03-17 04:20:15.000-0600

I have just testet on the latest CVS HEAD from today and it still does not work.

At 11:45 SayUnixTime says:
11
40
5

it should say:
11
5and
40
By: Frank Sautter (xylome) 2005-03-17 04:30:58.000-0600

ok i think this tiny patch i just uploaded should do it.

disclaimer is on file!
----
forget about it... this patch has to be bigger.... i will supply one shortly!

edited on: 03-17-05 04:34
By: Frank Sautter (xylome) 2005-03-17 04:47:23.000-0600

ok, the patch is a little bigger now and should do it...
as i'm german and my danish is very limited, could a danish native speaker please validate this code. especially the 4 digit year from 1900 to 2099 as this is handled special in german but i think also in danish.
By: tgj (tgj) 2005-03-17 07:49:55.000-0600

I am a Danish native, I have just tested your patch, and it nearly works:

This is what happened at 14:45

   -- Playing 'digits/day-4' (language 'da')
   -- Playing 'digits/h-17' (language 'da')
   -- Playing 'digits/mon-2' (language 'da')
   -- Playing 'digits/14' (language 'da')
   -- Playing 'digits/oclock' (language 'da')
   -- Playing 'digits/5-and' (language 'da')
   -- Playing 'digits/40' (language 'da')

and it should be:

   -- Playing 'digits/day-4' (language 'da')
   -- Playing 'digits/h-17' (language 'da')
   -- Playing 'digits/mon-2' (language 'da')
   -- Playing 'digits/oclock' (language 'da')
   -- Playing 'digits/14' (language 'da')
   -- Playing 'digits/5-and' (language 'da')
   -- Playing 'digits/40' (language 'da')

(oclock before 14)
By: Frank Sautter (xylome) 2005-03-17 09:51:42.000-0600

version 3 should do it this way
   -- Playing 'digits/day-4' (language 'da')
   -- Playing 'digits/h-17' (language 'da')
   -- Playing 'digits/mon-2' (language 'da')
   -- Playing 'digits/oclock' (language 'da')
   -- Playing 'digits/14' (language 'da')
   -- Playing 'digits/5-and' (language 'da')
   -- Playing 'digits/40' (language 'da')

please try it out and give feedback!
is the output of  SayUnixTime(-68100000) correct. this is extremly important as it's my date of birth - yes im b.u. ;-) no, it's because i want to know if the the years in the last century are pronounced right.
By: Frank Sautter (xylome) 2005-03-23 05:03:31.000-0600

could someone (ulle22, tgj) please give feedback if the patch works, so that it find it's way into cvs-head?
By: Mark Spencer (markster) 2005-03-26 01:46:53.000-0600

Waiting on some feedback here so this can be merged.
By: tgj (tgj) 2005-03-26 06:17:27.000-0600

Sorry for the delay, It is now saying the time OK but it is not saying the date OK, the dates should be said like numbers. something like this:

   -- Playing 'digits/day-6' (language 'da')
   -- Playing 'digits/6-and' (language 'da')
   -- Playing 'digits/20' (language 'da')
   -- Playing 'digits/mon-2' (language 'da')
   -- Playing 'digits/oclock' (language 'da')
   -- Playing 'digits/13' (language 'da')
   -- Playing 'digits/11' (language 'da')

This is how its done now:
   -- Playing 'digits/day-6' (language 'da')
   -- Playing 'digits/20' (language 'da')
   -- Playing 'digits/h-6' (language 'da')
   -- Playing 'digits/mon-2' (language 'da')
   -- Playing 'digits/oclock' (language 'da')
   -- Playing 'digits/13' (language 'da')
   -- Playing 'digits/11' (language 'da')
By: Frank Sautter (xylome) 2005-03-26 07:12:11.000-0600

is the day in the month said as an enumeration like 'digits/6-and' 'digits/20-h' or as a number like 'digits/6-and' 'digits/20'?
By: tgj (tgj) 2005-03-26 08:01:15.000-0600

It's said like: 'digits/6-and' 'digits/20-h'
By: Frank Sautter (xylome) 2005-03-26 18:01:19.000-0600

next try ;-)
please make intense tests with different dates using 'SayUnixTime(x)'
By: tgj (tgj) 2005-03-27 03:52:48.000-0600

on a clean build I get this error:

# patch -p0 < /root/danish-sayunixtime-v4.patch
(Stripping trailing CRs from patch.)
patching file say.c
patch unexpectedly ends in middle of line
Hunk ASTERISK-7 succeeded at 3339 with fuzz 1.

edited on: 03-27-05 03:53
By: Frank Sautter (xylome) 2005-03-27 04:35:54.000-0600

i will generate a new patch file on my linux machine on tuesday (seems as if eclipse under windows work quiet different)
By: Mark Spencer (markster) 2005-03-27 16:15:32.000-0600

Fixed in CVS head -- the patch did appear to work okay, but reopen if it still needs work.  Thanks!
By: Russell Bryant (russell) 2005-03-28 01:00:04.000-0600

not included in 1.0 since it is a new feature
By: Frank Sautter (xylome) 2005-04-01 04:09:51.000-0600

Reminder sent to markster

i forgot to include the little patch to 'app_sayunixtime.c' in my last patchfile which made it into the cvs.
would you please also merge 'danish-sayunixtime.patch' to the cvs?!?
By: Frank Sautter (xylome) 2005-04-20 09:01:38

Reminder sent to markster

i forgot to include the little patch to 'app_sayunixtime.c' in my last patchfile which made it into the cvs.
would you please also merge 'danish-sayunixtime.patch' to the cvs?!?
By: Michael Jerris (mikej) 2005-04-20 13:32:48

still need to merge the patch 'danish-sayunixtime.patch'
By: Michael Jerris (mikej) 2005-05-23 22:46:07

Can you verify which file still needs to be commited and if the patch still applies please.
By: Mark Spencer (markster) 2005-05-25 13:24:31

Fixed in CVS head.
By: Russell Bryant (russell) 2005-05-30 22:36:02

not included in 1.0 since it is a new feature
By: Digium Subversion (svnbot) 2008-01-15 15:28:54.000-0600

Repository: asterisk
Revision: 5275

U   trunk/say.c

------------------------------------------------------------------------
r5275 | markster | 2008-01-15 15:28:53 -0600 (Tue, 15 Jan 2008) | 2 lines

Repair danish format (bug ASTERISK-3176)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5275
By: Digium Subversion (svnbot) 2008-01-15 15:36:03.000-0600

Repository: asterisk
Revision: 5766

U   trunk/apps/app_sayunixtime.c

------------------------------------------------------------------------
r5766 | markster | 2008-01-15 15:36:03 -0600 (Tue, 15 Jan 2008) | 2 lines

Fix sayunixtime for Danish (bug ASTERISK-3176)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=5766