Summary:ASTERISK-03162: [patch] Voicemail formatting, cli command change
Reporter:Olle Johansson (oej)Labels:
Date Opened:2005-01-02 11:09:04.000-0600Date Closed:2011-06-07 14:04:56
Versions:Frequency of
Environment:Attachments:( 0) voicemail.txt
Description:This patch
* Changes bad formatting
* Adds info to cli help texts
* Changes cli commands to "voicemail show" instead of "show voicemail"
* Changes channel variables for vmauth to VM_ to be more inline with other variables


disclaimer on file
Not for stable, since we change cli syntax and channel variable names
Comments:By: Mark Spencer (markster) 2005-01-02 19:52:27.000-0600

I don't especially want to change the CLI options, that seems kinda needless, can we try again without that?

Also, changing the variables seems silly as they're essentially "local" variables.  Certainly neither that nor the CLI seems sufficiently cleaner to merit breaking backwards compatibility needlessly.

So basically just the format fix, thanks!

By: Mark Spencer (markster) 2005-01-07 01:08:41.000-0600

Any interest left in revising this?

By: Olle Johansson (oej) 2005-01-07 05:59:55.000-0600

Mark, I've been travelling - will fix this during the weekend. Can we add synonyms so that the old CLI commands still work, but the new ones is preferred? I really like having some similarity in the command structure - voicemail commands should start with "voicemail" as SIp starts with "sip", IAX2 with "IAX2" etc

By: Olle Johansson (oej) 2005-01-08 03:56:28.000-0600

Ok, did not change variable names. But... (being stubborn)...

Implements a hidden variable in the cli command structure, so that certain commands are not shown in help listings in the cli. They still work, for backwards compatibility, but help text show that they are replaced by a new syntax.

This way, we can safely move to a new CLI syntax without dropping support for existing apps. I still think "voicemail show" is more logical and follows the syntax set by other modules.

Mark, what do you think?

By: twisted (twisted) 2005-01-12 12:45:39.000-0600

might also wanna fix this line:
+"Check if voica mailbox exists";

Last I checked, voica isn't a valid word in the english language ;)

By: Mark Spencer (markster) 2005-01-12 23:34:53.000-0600

Naming then with _ at the beginning will make them not visible.

By: Tilghman Lesher (tilghman) 2005-01-19 13:44:39.000-0600

/me types "show", hits the <tab> key, and notes the huge number of other commands that start with "show".

I think your idea is dead in the water, Olle.

By: Olle Johansson (oej) 2005-01-30 12:33:50.000-0600

--lack of time and support--