Summary: | ASTERISK-03143: [patch] Allowto set the Bridge DTMF monitor in app_dial | ||
Reporter: | mochouinard (mochouinard) | Labels: | |
Date Opened: | 2004-12-31 02:03:29.000-0600 | Date Closed: | 2011-06-07 14:04:44 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_dial |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) dtmfforcecheck_rev2.patch ( 1) dtmfforcecheck.patch | |
Description: | I've added 2 flag, b and B, they are use to make dtmf to go throught res_features. ****** ADDITIONAL INFORMATION ****** This is to be used with bug 2955 | ||
Comments: | By: mochouinard (mochouinard) 2004-12-31 02:11:49.000-0600 Disclamed By: nick (nick) 2004-12-31 02:20:22.000-0600 Could you explain a little better what this patch does and why? By: mochouinard (mochouinard) 2004-12-31 10:48:40.000-0600 0002955 require the channel is being bridged throught * so * or other DTMF defined can process DTMF signal. The 2 flag is made to check sender or sendee dtmf. By: mochouinard (mochouinard) 2004-12-31 12:37:55.000-0600 Rev_2 is a proposal to change the process we have rightnow. I beleive it better to have it always used into the sturucture we devined, than passing it throught the functions parameters. Also it make the channel.c check only for 1 variable instead of 2 variable that doesnt make sence as channel specific settings. Please let me know what you think By: twisted (twisted) 2004-12-31 14:52:38.000-0600 So rather than having individual options, we set up and incoming and outgoing set and determine what options under that struct is set? ie: outgoing->allowdisconnect incoming->allowdisconnect outgoing->allowredir incoming->allowredir outgoing->listendtmf incoming->listendtmf that kind of thing? If so, I'm all for it, as that would allow for easy additions of other bridging features from other applicaitons. By: mochouinard (mochouinard) 2005-01-04 14:58:06.000-0600 anthm I think posted a new patch to make channels flags easier to manage. So I'll close this bug since the bug 3241 also include this (this patch was for 2955) By: mochouinard (mochouinard) 2005-01-04 14:59:41.000-0600 Wont apply to head due to changes. This patch will be discontinued of favor of new current implementation |