[Home]

Summary:ASTERISK-03139: [PATCH] centralize common options, switch more opts to flags
Reporter:Kevin P. Fleming (kpfleming)Labels:
Date Opened:2004-12-30 11:12:10.000-0600Date Closed:2008-01-15 15:18:56.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) sip_common_options_rev1.diff.txt
Description:The attached patch converts another bunch of SIP peer/user config settings to flag bits from ints. It also removes the config parsing code for these items from the three places it was located before, and puts it into a single function.

- 5 (or 6 with OSP) ints removed from pvt/peer/user
- 101 net lines of code removed
- global options now handled consistently

There should be _no_ functional changes here, except for some global options that were not automatically applied:

peers now get global USECLIENTCODE and INSECURE
temp_peers now get global USECLIENTCODE and INSECURE
users now get global USECLIENTCODE, INSECURE and PROMISCREDIR

****** ADDITIONAL INFORMATION ******

Disclaimer is on file.
Comments:By: Mark Spencer (markster) 2004-12-30 11:43:18.000-0600

Added to CVS head, thanks!

By: Digium Subversion (svnbot) 2008-01-15 15:18:56.000-0600

Repository: asterisk
Revision: 4603

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r4603 | markster | 2008-01-15 15:18:56 -0600 (Tue, 15 Jan 2008) | 2 lines

Switch more options into flags (bug ASTERISK-3139)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=4603